| Message ID | 1637650813-16654-3-git-send-email-rnayak@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Add support for the sc7280 CRD board | expand |
On Tue, Nov 23, 2021 at 12:30:11PM +0530, Rajendra Nayak wrote: > CRD (Compute Reference Design) is a sc7280 based board, largely > derived from the existing IDP board design with some key deltas > 1. has EC and H1 over SPI similar to IDP2 > 2. touchscreen and trackpad support > 3. eDP display > > We just add the barebones dts file here, subsequent patches will > add support for EC/H1 and other components. > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-crd.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 6b816eb..b18708c 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > new file mode 100644 > index 0000000..09d02c2 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -0,0 +1,31 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * sc7280 CRD board device tree source > + * > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "sc7280-idp.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. sc7280 CRD platform"; > + compatible = "qcom,sc7280-crd", "google,hoglin-rev0", "qcom,sc7280"; As per my comment on the binding there should also be a "google,hoglin" without a revision suffix, also it seems there are already CRDs with higher rev numbers. > + > + aliases { > + serial0 = &uart5; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&nvme_pwren { > + pins = "gpio51"; > +}; > + > +&nvme_3v3_regulator { > + gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; > +}; uber-nit: 'nvme_3v3_regulator' should be before 'nvme_pwren', assuming alphabetical/ASCII ordering is used.
On 11/23/2021 9:44 PM, Matthias Kaehlcke wrote: > On Tue, Nov 23, 2021 at 12:30:11PM +0530, Rajendra Nayak wrote: >> CRD (Compute Reference Design) is a sc7280 based board, largely >> derived from the existing IDP board design with some key deltas >> 1. has EC and H1 over SPI similar to IDP2 >> 2. touchscreen and trackpad support >> 3. eDP display >> >> We just add the barebones dts file here, subsequent patches will >> add support for EC/H1 and other components. >> >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-crd.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 6b816eb..b18708c 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts >> new file mode 100644 >> index 0000000..09d02c2 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts >> @@ -0,0 +1,31 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * sc7280 CRD board device tree source >> + * >> + * Copyright (c) 2021, The Linux Foundation. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "sc7280-idp.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. sc7280 CRD platform"; >> + compatible = "qcom,sc7280-crd", "google,hoglin-rev0", "qcom,sc7280"; > > As per my comment on the binding there should also be a "google,hoglin" > without a revision suffix, also it seems there are already CRDs with higher > rev numbers. right i will remove the -revs for now. > >> + >> + aliases { >> + serial0 = &uart5; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> +}; >> + >> +&nvme_pwren { >> + pins = "gpio51"; >> +}; >> + >> +&nvme_3v3_regulator { >> + gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; >> +}; > > uber-nit: 'nvme_3v3_regulator' should be before 'nvme_pwren', assuming > alphabetical/ASCII ordering is used. thanks will fix >
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 6b816eb..b18708c 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts new file mode 100644 index 0000000..09d02c2 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -0,0 +1,31 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * sc7280 CRD board device tree source + * + * Copyright (c) 2021, The Linux Foundation. All rights reserved. + */ + +/dts-v1/; + +#include "sc7280-idp.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. sc7280 CRD platform"; + compatible = "qcom,sc7280-crd", "google,hoglin-rev0", "qcom,sc7280"; + + aliases { + serial0 = &uart5; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&nvme_pwren { + pins = "gpio51"; +}; + +&nvme_3v3_regulator { + gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; +};
CRD (Compute Reference Design) is a sc7280 based board, largely derived from the existing IDP board design with some key deltas 1. has EC and H1 over SPI similar to IDP2 2. touchscreen and trackpad support 3. eDP display We just add the barebones dts file here, subsequent patches will add support for EC/H1 and other components. Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sc7280-crd.dts | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-crd.dts