| Message ID | 1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Remove USB2 nodes from SC7280 IDP common dtsi file | expand |
On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote: > Remove USB2 controller and phy nodes from common dtsi file as it is > required only for SKU1 board. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> A series shouldn't break things if it is only applied partially (in order). In this case the USB2 controller wouldn't work on the SKU1 board if only this patch is applied. It should be squashed with patch 2 of this series ("arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board"). Also doing the move in a single patch instead of two separate patches for remove and add makes it easier to review the latter part, since it's evident from the patch itself that it's just a move.
On 11/29/2021 11:32 PM, Matthias Kaehlcke wrote: > On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote: >> Remove USB2 controller and phy nodes from common dtsi file as it is >> required only for SKU1 board. >> >> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > A series shouldn't break things if it is only applied partially (in order). In > this case the USB2 controller wouldn't work on the SKU1 board if only this patch > is applied. It should be squashed with patch 2 of this series ("arm64: qcom: > sc7280: Add USB2 controller and phy nodes for SKU1 board"). > > Also doing the move in a single patch instead of two separate patches for remove > and add makes it easier to review the latter part, since it's evident from the > patch itself that it's just a move. Ok. Will do in next version.
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index d623d71..c54ad62 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -398,22 +398,6 @@ vdda-pll-supply = <&vreg_l1b_0p8>; }; -&usb_2 { - status = "okay"; -}; - -&usb_2_dwc3 { - dr_mode = "peripheral"; -}; - -&usb_2_hsphy { - status = "okay"; - - vdda-pll-supply = <&vreg_l10c_0p8>; - vdda33-supply = <&vreg_l2b_3p0>; - vdda18-supply = <&vreg_l1c_1p8>; -}; - &uart7 { status = "okay";
Remove USB2 controller and phy nodes from common dtsi file as it is required only for SKU1 board. Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 16 ---------------- 1 file changed, 16 deletions(-)