| Message ID | 1637837815-8532-3-git-send-email-quic_c_sanm@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Remove USB2 nodes from SC7280 IDP common dtsi file | expand |
On Thu 25 Nov 04:56 CST 2021, Sandeep Maheswaram wrote: > Adding USB2 controller and phy nodes for SC7280 SKU1 board. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index 9b991ba..ffd483d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -80,3 +80,19 @@ > qcom,pre-scaling = <1 1>; > }; > }; > + > +&usb_2 { > + status = "okay"; > +}; > + > +&usb_2_dwc3 { > + dr_mode = "host"; The commit messages doesn't capture why the mode changes from peripheral to host. > +}; > + > +&usb_2_hsphy { Is this specific to this SKU? Is there a reason not to keep this in the dtsi? Please squash the two patches and please write a proper commit message. Thanks, Bjorn > + status = "okay"; > + > + vdda-pll-supply = <&vreg_l10c_0p8>; > + vdda33-supply = <&vreg_l2b_3p0>; > + vdda18-supply = <&vreg_l1c_1p8>; > +}; > -- > 2.7.4 >
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index 9b991ba..ffd483d 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -80,3 +80,19 @@ qcom,pre-scaling = <1 1>; }; }; + +&usb_2 { + status = "okay"; +}; + +&usb_2_dwc3 { + dr_mode = "host"; +}; + +&usb_2_hsphy { + status = "okay"; + + vdda-pll-supply = <&vreg_l10c_0p8>; + vdda33-supply = <&vreg_l2b_3p0>; + vdda18-supply = <&vreg_l1c_1p8>; +};
Adding USB2 controller and phy nodes for SC7280 SKU1 board. Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)