| Message ID | 1644207878-19839-1-git-send-email-quic_saluvala@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 crd board | expand |
+ bjorn -----Original Message----- From: Sai Teja Aluvala <quic_saluvala@quicinc.com> Sent: Monday, February 7, 2022 9:55 AM To: marcel@holtmann.org; johan.hedberg@gmail.com Cc: mka@chromium.org; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; quic_hbandi <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium.org; Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com> Subject: [PATCH v1] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 crd board Add Bluetooth SoC WCN6750 node for SC7280 crd board Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index cd2755c..53ea3b4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -23,6 +23,10 @@ }; }; +&bluetooth { + vddio-supply = <&vreg_l18b_1p8>; +}; + ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>;
Hi Sai,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.17-rc3]
[cannot apply to next-20220207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sai-Teja-Aluvala/arm64-dts-qcom-sc7280-Add-bluetooth-node-on-SC7280-crd-board/20220207-141304
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-s031-20220207 (https://download.01.org/0day-ci/archive/20220207/202202071900.HBQ0tQbr-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/36d7dc511b4181b7243171a2949e2f097d799d40
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sai-Teja-Aluvala/arm64-dts-qcom-sc7280-Add-bluetooth-node-on-SC7280-crd-board/20220207-141304
git checkout 36d7dc511b4181b7243171a2949e2f097d799d40
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sc7280-crd.dts:26.1-11 Label or path bluetooth not found
FATAL ERROR: Syntax error parsing input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On Mon, Feb 07, 2022 at 09:54:38AM +0530, Sai Teja Aluvala wrote: > Subject: arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 crd board > > Add Bluetooth SoC WCN6750 node for SC7280 crd board That doesn't describe accurately what this patch does. The CRD already has a Bluetooth node - from including sc7280-idp.dtsi - what this patch does is setting the vddio supply for Bluetooth on the CRD.
-----Original Message----- From: Matthias Kaehlcke <mka@chromium.org> Sent: Monday, February 7, 2022 10:43 PM To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com> Cc: marcel@holtmann.org; johan.hedberg@gmail.com; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; quic_hbandi <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium.org Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 crd board On Mon, Feb 07, 2022 at 09:54:38AM +0530, Sai Teja Aluvala wrote: > Subject: arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 crd > board > > Add Bluetooth SoC WCN6750 node for SC7280 crd board That doesn't describe accurately what this patch does. The CRD already has a Bluetooth node - from including sc7280-idp.dtsi - what this patch does is setting the vddio supply for Bluetooth on the CRD. [Sai]: will update in next patch
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index cd2755c..53ea3b4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -23,6 +23,10 @@ }; }; +&bluetooth { + vddio-supply = <&vreg_l18b_1p8>; +}; + ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>;
Add Bluetooth SoC WCN6750 node for SC7280 crd board Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ 1 file changed, 4 insertions(+)