| Message ID | 1644331940-18986-2-git-send-email-quic_c_skakit@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand |
On Tue, 08 Feb 2022 20:22:15 +0530, Satya Priya wrote: > Add bindings for pm8008 pmic regulators. > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > --- > Changes in V2: > - Moved this patch before "mfd: pm8008: Add pm8008 regulator node" to > resolve dtschema errors. Removed regulator-min-microvolt and > regulator-max-microvolt properties. > > Changes in V3: > - As per Rob's comments added standard unit suffix for mindropout property, > added blank lines where required and added description for reg property. > > Changes in V4: > - Changed compatible string to "com,pm8008-regulators" > - Moved "regulator-min-dropout-voltage-microvolt" to regulator.yaml as > separate patch. > > Changes in V5: > - Removed the separate compatible for pm8008 regulator driver. > - Moved the supply nodes to chip level. > - Removed min-dropout property. > > .../bindings/regulator/qcom,pm8008-regulator.yaml | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
Quoting Satya Priya (2022-02-08 06:52:15) > diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > new file mode 100644 > index 0000000..0098845 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings > + > +maintainers: > + - Satya Priya <skakit@codeaurora.org> > + > +description: > + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC > + containing 7 LDO regulators. > + > +patternProperties: > + "^LDO[1-7]$": Any reason it needs to be capitalized vs. lowercase ldo? > + type: object > + $ref: "regulator.yaml#" > + description: PM8008 regulator peripherals of PM8008 regulator device > + > + properties: > + regulator-name: true > + > + required: > + - regulator-name
On Tue 08 Feb 08:52 CST 2022, Satya Priya wrote: > Add bindings for pm8008 pmic regulators. > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > --- > Changes in V2: > - Moved this patch before "mfd: pm8008: Add pm8008 regulator node" to > resolve dtschema errors. Removed regulator-min-microvolt and > regulator-max-microvolt properties. > > Changes in V3: > - As per Rob's comments added standard unit suffix for mindropout property, > added blank lines where required and added description for reg property. > > Changes in V4: > - Changed compatible string to "com,pm8008-regulators" > - Moved "regulator-min-dropout-voltage-microvolt" to regulator.yaml as > separate patch. > > Changes in V5: > - Removed the separate compatible for pm8008 regulator driver. > - Moved the supply nodes to chip level. > - Removed min-dropout property. > > .../bindings/regulator/qcom,pm8008-regulator.yaml | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > new file mode 100644 > index 0000000..0098845 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings > + > +maintainers: > + - Satya Priya <skakit@codeaurora.org> > + > +description: > + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC > + containing 7 LDO regulators. > + > +patternProperties: > + "^LDO[1-7]$": Please make this lower case, to match all other regulator bindings. > + type: object > + $ref: "regulator.yaml#" > + description: PM8008 regulator peripherals of PM8008 regulator device > + > + properties: > + regulator-name: true > + > + required: > + - regulator-name Why is regulator-name a (and the only) required property? Regards, Bjorn > + > + unevaluatedProperties: false > + > +additionalProperties: false > +... > -- > 2.7.4 >
On 2/10/2022 6:54 AM, Stephen Boyd wrote: > Quoting Satya Priya (2022-02-08 06:52:15) >> diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml >> new file mode 100644 >> index 0000000..0098845 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml >> @@ -0,0 +1,31 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings >> + >> +maintainers: >> + - Satya Priya <skakit@codeaurora.org> >> + >> +description: >> + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC >> + containing 7 LDO regulators. >> + >> +patternProperties: >> + "^LDO[1-7]$": > Any reason it needs to be capitalized vs. lowercase ldo? I'll change this to lowercase. >> + type: object >> + $ref: "regulator.yaml#" >> + description: PM8008 regulator peripherals of PM8008 regulator device >> + >> + properties: >> + regulator-name: true >> + >> + required: >> + - regulator-name
On 2/11/2022 6:13 AM, Bjorn Andersson wrote: > On Tue 08 Feb 08:52 CST 2022, Satya Priya wrote: > >> Add bindings for pm8008 pmic regulators. >> >> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> >> --- >> Changes in V2: >> - Moved this patch before "mfd: pm8008: Add pm8008 regulator node" to >> resolve dtschema errors. Removed regulator-min-microvolt and >> regulator-max-microvolt properties. >> >> Changes in V3: >> - As per Rob's comments added standard unit suffix for mindropout property, >> added blank lines where required and added description for reg property. >> >> Changes in V4: >> - Changed compatible string to "com,pm8008-regulators" >> - Moved "regulator-min-dropout-voltage-microvolt" to regulator.yaml as >> separate patch. >> >> Changes in V5: >> - Removed the separate compatible for pm8008 regulator driver. >> - Moved the supply nodes to chip level. >> - Removed min-dropout property. >> >> .../bindings/regulator/qcom,pm8008-regulator.yaml | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml >> >> diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml >> new file mode 100644 >> index 0000000..0098845 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml >> @@ -0,0 +1,31 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings >> + >> +maintainers: >> + - Satya Priya <skakit@codeaurora.org> >> + >> +description: >> + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC >> + containing 7 LDO regulators. >> + >> +patternProperties: >> + "^LDO[1-7]$": > Please make this lower case, to match all other regulator bindings. Okay. >> + type: object >> + $ref: "regulator.yaml#" >> + description: PM8008 regulator peripherals of PM8008 regulator device >> + >> + properties: >> + regulator-name: true >> + >> + required: >> + - regulator-name > Why is regulator-name a (and the only) required property? It is not a required property, I'll correct this. > Regards, > Bjorn > >> + >> + unevaluatedProperties: false >> + >> +additionalProperties: false >> +... >> -- >> 2.7.4 >>
diff --git a/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml new file mode 100644 index 0000000..0098845 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml @@ -0,0 +1,31 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/qcom,pm8008-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings + +maintainers: + - Satya Priya <skakit@codeaurora.org> + +description: + Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC + containing 7 LDO regulators. + +patternProperties: + "^LDO[1-7]$": + type: object + $ref: "regulator.yaml#" + description: PM8008 regulator peripherals of PM8008 regulator device + + properties: + regulator-name: true + + required: + - regulator-name + + unevaluatedProperties: false + +additionalProperties: false +...
Add bindings for pm8008 pmic regulators. Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> --- Changes in V2: - Moved this patch before "mfd: pm8008: Add pm8008 regulator node" to resolve dtschema errors. Removed regulator-min-microvolt and regulator-max-microvolt properties. Changes in V3: - As per Rob's comments added standard unit suffix for mindropout property, added blank lines where required and added description for reg property. Changes in V4: - Changed compatible string to "com,pm8008-regulators" - Moved "regulator-min-dropout-voltage-microvolt" to regulator.yaml as separate patch. Changes in V5: - Removed the separate compatible for pm8008 regulator driver. - Moved the supply nodes to chip level. - Removed min-dropout property. .../bindings/regulator/qcom,pm8008-regulator.yaml | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml