| Message ID | 1647937864-25661-1-git-send-email-quic_saluvala@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [RESEND,v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms | expand |
On Tue 22 Mar 03:31 CDT 2022, Sai Teja Aluvala wrote: > Add IO regulator handler in SC7280 CRD based platforms. > As IO regulator varies in different SC7280 platforms > updating this handler in individual platform bluetooth node. > To me a significant part of this change is "bluetooth", yet it's not mentioned until the very end of the commit message. Please update your $subject to be more to the point and to include "bluetooth", and please don't repeat $subject as the first line in your commit message. Thanks, Bjorn > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> > --- > v3: Updated commit text to reflect the change > v2: updated reviewer comments. > v1: intial patch > --- > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index cd2755c..53ea3b4 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -23,6 +23,10 @@ > }; > }; > > +&bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. >
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index cd2755c..53ea3b4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -23,6 +23,10 @@ }; }; +&bluetooth { + vddio-supply = <&vreg_l18b_1p8>; +}; + ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>;
Add IO regulator handler in SC7280 CRD based platforms. As IO regulator varies in different SC7280 platforms updating this handler in individual platform bluetooth node. Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> --- v3: Updated commit text to reflect the change v2: updated reviewer comments. v1: intial patch --- --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ 1 file changed, 4 insertions(+)