diff mbox series

[V8,6/7] arm64: dts: qcom: pm8008-regulators: Add base dts file for pm8008 regulators

Message ID 1648209491-30165-7-git-send-email-quic_c_skakit@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand

Commit Message

Satya Priya Kakitapalli (Temp) March 25, 2022, 11:58 a.m. UTC
Add base DTS file for pm8008 regulators with 7 ldo nodes.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
---
Changes in V8:
 - Previously added pm8008 dtsi file is split into 2 files, one for infra
   and other for regulators.

 arch/arm64/boot/dts/qcom/pm8008-regulators.dtsi | 37 +++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8008-regulators.dtsi

Comments

Stephen Boyd March 25, 2022, 5:43 p.m. UTC | #1
Quoting Satya Priya (2022-03-25 04:58:10)
> Add base DTS file for pm8008 regulators with 7 ldo nodes.
>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> Changes in V8:
>  - Previously added pm8008 dtsi file is split into 2 files, one for infra
>    and other for regulators.

Does pm8008 come in one package that gets soldered down on the board? If
so, this should be one file instead of two, i.e. pm8008.dtsi. We don't
make a -regulators dtsi file for other pmics.
Satya Priya Kakitapalli (Temp) March 30, 2022, 10:36 a.m. UTC | #2
On 3/25/2022 11:13 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-03-25 04:58:10)
>> Add base DTS file for pm8008 regulators with 7 ldo nodes.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
>> ---
>> Changes in V8:
>>   - Previously added pm8008 dtsi file is split into 2 files, one for infra
>>     and other for regulators.
> Does pm8008 come in one package that gets soldered down on the board? If
> so, this should be one file instead of two, i.e. pm8008.dtsi. We don't
> make a -regulators dtsi file for other pmics.


Yes, pm8008 is a single chip.

You're right I should add only one pm8008.dtsi (including regulators)
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm8008-regulators.dtsi b/arch/arm64/boot/dts/qcom/pm8008-regulators.dtsi
new file mode 100644
index 0000000..3bfdefd
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm8008-regulators.dtsi
@@ -0,0 +1,37 @@ 
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2022, The Linux Foundation. All rights reserved.
+
+pm8008_regulators: pmic@9 {
+	compatible = "qcom,pm8008-regulators";
+	reg = <0x9>;
+	#address-cells = <0>;
+	#size-cells = <0>;
+
+	pm8008_l1: ldo1 {
+		regulator-name = "pm8008_l1";
+	};
+
+	pm8008_l2: ldo2 {
+		regulator-name = "pm8008_l2";
+	};
+
+	pm8008_l3: ldo3 {
+		regulator-name = "pm8008_l3";
+	};
+
+	pm8008_l4: ldo4 {
+		regulator-name = "pm8008_l4";
+	};
+
+	pm8008_l5: ldo5 {
+		regulator-name = "pm8008_l5";
+	};
+
+	pm8008_l6: ldo6 {
+		regulator-name = "pm8008_l6";
+	};
+
+	pm8008_l7: ldo7 {
+		regulator-name = "pm8008_l7";
+	};
+};