| Message ID | 1650349697-13540-3-git-send-email-quic_vnivarth@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold | expand |
Hi, On Mon, Apr 18, 2022 at 11:28 PM Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote: > > WLAN rail was leaking power during RBSC/sleep even after turning BT off. > Change sleep pinctrl configuration to handle same. > > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> > --- > v4: modify subject of patch to indicate file it is applying to > v3: apply same change to active state and other sc7280*.dts* as well > v2: used bias-bus-hold as per review comments > v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only > --- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) You should have carried my tag forward. In any case: Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index b833ba1..602ebd4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -398,8 +398,11 @@ mos_bt_uart: &uart7 { /* For mos_bt_uart */ &qup_uart7_cts { - /* Configure a pull-down on CTS to match the pull of the Bluetooth module. */ - bias-pull-down; + /* + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. + */ + bias-bus-hold; }; /* For mos_bt_uart */ @@ -490,10 +493,10 @@ mos_bt_uart: &uart7 { pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; /* For mos_bt_uart */
WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> --- v4: modify subject of patch to indicate file it is applying to v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)