| Message ID | 1655200111-18357-3-git-send-email-quic_c_skakit@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand |
On Tue, 14 Jun 2022, Satya Priya wrote: > Change the address cells as '2' so that the first cell > describes the i2c address offset of the clients. > This helps us to define the child nodes of all > clients under the same parent mfd node, instead of > adding separate mfd DT nodes. > > Change the gpios reg value accordingly. > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes in V15: > - None. > > Changes in V14: > - None. > > Changes in V13: > - Fixed nit. > > Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Applied, thanks.
On Thu, 16 Jun 2022, Lee Jones wrote: > On Tue, 14 Jun 2022, Satya Priya wrote: > > > Change the address cells as '2' so that the first cell > > describes the i2c address offset of the clients. > > This helps us to define the child nodes of all > > clients under the same parent mfd node, instead of > > adding separate mfd DT nodes. > > > > Change the gpios reg value accordingly. > > > > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Changes in V15: > > - None. > > > > Changes in V14: > > - None. > > > > Changes in V13: > > - Fixed nit. > > > > Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > Applied, thanks. Sorry, wrong key-combo: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml index a89649c..a54d1ce0 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml @@ -39,7 +39,7 @@ properties: interrupt-controller: true "#address-cells": - const: 1 + const: 2 "#size-cells": const: 0 @@ -48,7 +48,7 @@ properties: maxItems: 1 patternProperties: - "^gpio@[0-9a-f]+$": + "^gpio@0,[0-9a-f]+$": type: object description: | @@ -61,7 +61,7 @@ patternProperties: - const: qcom,spmi-gpio reg: - description: Peripheral address of one of the two GPIO peripherals. + description: Peripheral offset and address of one of the two GPIO peripherals. maxItems: 1 gpio-controller: true @@ -110,7 +110,7 @@ examples: pm8008i@8 { compatible = "qcom,pm8008"; reg = <0x8>; - #address-cells = <1>; + #address-cells = <2>; #size-cells = <0>; interrupt-controller; #interrupt-cells = <2>; @@ -120,9 +120,9 @@ examples: reset-gpios = <&pm8350c_gpios 4 GPIO_ACTIVE_LOW>; - pm8008_gpios: gpio@c000 { + pm8008_gpios: gpio@0,c000 { compatible = "qcom,pm8008-gpio", "qcom,spmi-gpio"; - reg = <0xc000>; + reg = <0x0 0xc000>; gpio-controller; gpio-ranges = <&pm8008_gpios 0 0 2>; #gpio-cells = <2>;