diff mbox series

[v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp

Message ID 1657556603-15024-1-git-send-email-quic_khsieh@quicinc.com (mailing list archive)
State Accepted
Headers show
Series [v2] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp | expand

Commit Message

Kuogee Hsieh July 11, 2022, 4:23 p.m. UTC
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.

Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
 2 files changed, 5 deletions(-)

Comments

Doug Anderson July 11, 2022, 4:47 p.m. UTC | #1
Hi,

On Mon, Jul 11, 2022 at 9:23 AM Kuogee Hsieh <quic_khsieh@quicinc.com> wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
>  2 files changed, 5 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Bjorn Andersson July 19, 2022, midnight UTC | #2
On Mon 11 Jul 11:23 CDT 2022, Kuogee Hsieh wrote:

Please double check that the subject prefix matches existing changes
next time.

Thanks,
Bjorn

> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi     | 3 ---
>  2 files changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index ed800817..3f8996c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -435,8 +435,6 @@ ap_i2c_tpm: &i2c14 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&dp_hot_plug_det>;
>  	data-lanes = <0 1>;
> -	vdda-1p2-supply = <&vdd_a_usbssdp_0_1p2>;
> -	vdda-0p9-supply = <&vdd_a_usbssdp_0_core>;
>  };
>  
>  &mdss_mdp {
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> index 4c25ffc..7adf31b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
> @@ -311,9 +311,6 @@
>  
>  /* NOTE: Not all Qcards have eDP connector stuffed */
>  &mdss_edp {
> -	vdda-0p9-supply = <&vdd_a_edp_0_0p9>;
> -	vdda-1p2-supply = <&vdd_a_edp_0_1p2>;
> -
>  	aux-bus {
>  		edp_panel: panel {
>  			compatible = "edp-panel";
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Bjorn Andersson July 19, 2022, 4:48 a.m. UTC | #3
On Mon, 11 Jul 2022 09:23:23 -0700, Kuogee Hsieh wrote:
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
> 
> 

Applied, thanks!

[1/1] arm64: dta: qcom: sc7280: delete vdda-1p2 and vdda-0p9 from both dp and edp
      commit: 8ed85d1e515ff5f302a929308c7ccc06bec68632

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index ed800817..3f8996c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -435,8 +435,6 @@  ap_i2c_tpm: &i2c14 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&dp_hot_plug_det>;
 	data-lanes = <0 1>;
-	vdda-1p2-supply = <&vdd_a_usbssdp_0_1p2>;
-	vdda-0p9-supply = <&vdd_a_usbssdp_0_core>;
 };
 
 &mdss_mdp {
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index 4c25ffc..7adf31b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -311,9 +311,6 @@ 
 
 /* NOTE: Not all Qcards have eDP connector stuffed */
 &mdss_edp {
-	vdda-0p9-supply = <&vdd_a_edp_0_0p9>;
-	vdda-1p2-supply = <&vdd_a_edp_0_1p2>;
-
 	aux-bus {
 		edp_panel: panel {
 			compatible = "edp-panel";