| Message ID | 1659536480-5176-5-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Update ADSP pil loader for SC7280 platform | expand |
On 03/08/2022 17:21, Srinivasa Rao Mandadapu wrote: > Update hard coded values with appropriate macro names. 'Replace' Other than that, Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > --- > drivers/remoteproc/qcom_q6v5_adsp.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c > index bb4494c..a9fcb5c 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -54,6 +54,9 @@ > > #define QCOM_Q6V5_RPROC_PROXY_PD_MAX 3 > > +#define LPASS_BOOT_CORE_START BIT(0) > +#define LPASS_BOOT_CMD_START BIT(0) > + > struct adsp_pil_data { > int crash_reason_smem; > const char *firmware_name; > @@ -364,10 +367,10 @@ static int adsp_start(struct rproc *rproc) > writel(adsp->mem_phys >> 4, adsp->qdsp6ss_base + RST_EVB_REG); > > /* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */ > - writel(0x1, adsp->qdsp6ss_base + CORE_START_REG); > + writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG); > > /* Trigger boot FSM to start QDSP6 */ > - writel(0x1, adsp->qdsp6ss_base + BOOT_CMD_REG); > + writel(LPASS_BOOT_CMD_START, adsp->qdsp6ss_base + BOOT_CMD_REG); > > /* Wait for core to come out of reset */ > ret = readl_poll_timeout(adsp->qdsp6ss_base + BOOT_STATUS_REG,
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index bb4494c..a9fcb5c 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -54,6 +54,9 @@ #define QCOM_Q6V5_RPROC_PROXY_PD_MAX 3 +#define LPASS_BOOT_CORE_START BIT(0) +#define LPASS_BOOT_CMD_START BIT(0) + struct adsp_pil_data { int crash_reason_smem; const char *firmware_name; @@ -364,10 +367,10 @@ static int adsp_start(struct rproc *rproc) writel(adsp->mem_phys >> 4, adsp->qdsp6ss_base + RST_EVB_REG); /* De-assert QDSP6 stop core. QDSP6 will execute after out of reset */ - writel(0x1, adsp->qdsp6ss_base + CORE_START_REG); + writel(LPASS_BOOT_CORE_START, adsp->qdsp6ss_base + CORE_START_REG); /* Trigger boot FSM to start QDSP6 */ - writel(0x1, adsp->qdsp6ss_base + BOOT_CMD_REG); + writel(LPASS_BOOT_CMD_START, adsp->qdsp6ss_base + BOOT_CMD_REG); /* Wait for core to come out of reset */ ret = readl_poll_timeout(adsp->qdsp6ss_base + BOOT_STATUS_REG,
Update hard coded values with appropriate macro names. Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> --- drivers/remoteproc/qcom_q6v5_adsp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)