| Message ID | 1678164097-13247-3-git-send-email-quic_mmanikan@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add multipd remoteproc support | expand |
On 3/7/2023 10:11 AM, Manikanta Mylavarapu wrote: > Add compatible for the Qualcomm IPQ5018 APCS block. > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 9a46dbc6d03f..91f4e0454fe3 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -23,6 +23,7 @@ properties: > - const: qcom,ipq6018-apcs-apps-global > - items: > - enum: > + - qcom,ipq5018-apcs-apps-global > No, we can use the fallback mechanism as done for IPQ5332. Please refer https://lore.kernel.org/linux-arm-msm/20230217083308.12017-5-quic_kathirav@quicinc.com/ Thanks, Kathiravan T.
On 07/03/2023 05:41, Manikanta Mylavarapu wrote: > Add compatible for the Qualcomm IPQ5018 APCS block. Is it compatible with ipq6018 or ipq8074? Your driver tells it is... > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Best regards, Krzysztof
On 3/7/2023 11:35 AM, Kathiravan T wrote: > > On 3/7/2023 10:11 AM, Manikanta Mylavarapu wrote: >> Add compatible for the Qualcomm IPQ5018 APCS block. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 9a46dbc6d03f..91f4e0454fe3 100644 >> --- >> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ >> b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -23,6 +23,7 @@ properties: >> - const: qcom,ipq6018-apcs-apps-global >> - items: >> - enum: >> + - qcom,ipq5018-apcs-apps-global > > No, we can use the fallback mechanism as done for IPQ5332. Please > refer > https://lore.kernel.org/linux-arm-msm/20230217083308.12017-5-quic_kathirav@quicinc.com/ > > > Thanks, > > Kathiravan T. > Sure. I will also use same fallback mechanism for IPQ5018. Thanks & Regards, Manikanta.
On 3/7/2023 8:51 PM, Krzysztof Kozlowski wrote: > On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >> Add compatible for the Qualcomm IPQ5018 APCS block. > > Is it compatible with ipq6018 or ipq8074? Your driver tells it is... > >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> > > > > Best regards, > Krzysztof > Yeah, it's compatible. I will use fallback mechanism available here https://lore.kernel.org/linux-arm-msm/20230217083308.12017-5-quic_kathirav@quicinc.com/ Thanks & Regards, Manikanta.
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 9a46dbc6d03f..91f4e0454fe3 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -23,6 +23,7 @@ properties: - const: qcom,ipq6018-apcs-apps-global - items: - enum: + - qcom,ipq5018-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - qcom,msm8996-apcs-hmss-global @@ -152,6 +153,7 @@ allOf: compatible: contains: enum: + - qcom,ipq5018-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global then:
Add compatible for the Qualcomm IPQ5018 APCS block. Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 ++ 1 file changed, 2 insertions(+)