| Message ID | 1682413909-24927-1-git-send-email-mantas@8devices.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks | expand |
On 4/25/23 10:11, Mantas Pucka wrote: > SDCC clocks must be rounded down to avoid overclocking the controller. > > Fixes: d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support") > Signed-off-by: Mantas Pucka <mantas@8devices.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > v2: remove unnecessary newline in commit message > > drivers/clk/qcom/gcc-ipq6018.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c > index 3f9c2f61a5d9..5c5d1b04ea7a 100644 > --- a/drivers/clk/qcom/gcc-ipq6018.c > +++ b/drivers/clk/qcom/gcc-ipq6018.c > @@ -1654,7 +1654,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { > .name = "sdcc1_apps_clk_src", > .parent_data = gcc_xo_gpll0_gpll2_gpll0_out_main_div2, > .num_parents = 4, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_floor_ops, > }, > }; >
On Tue, 25 Apr 2023 12:11:49 +0300, Mantas Pucka wrote: > SDCC clocks must be rounded down to avoid overclocking the controller. > > Applied, thanks! [1/1] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks commit: 56e5ae0116aef87273cf1812d608645b076e4f02 Best regards,
diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c index 3f9c2f61a5d9..5c5d1b04ea7a 100644 --- a/drivers/clk/qcom/gcc-ipq6018.c +++ b/drivers/clk/qcom/gcc-ipq6018.c @@ -1654,7 +1654,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = { .name = "sdcc1_apps_clk_src", .parent_data = gcc_xo_gpll0_gpll2_gpll0_out_main_div2, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
SDCC clocks must be rounded down to avoid overclocking the controller. Fixes: d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support") Signed-off-by: Mantas Pucka <mantas@8devices.com> --- v2: remove unnecessary newline in commit message drivers/clk/qcom/gcc-ipq6018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)