From patchwork Fri May 15 05:23:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kenneth Westfield X-Patchwork-Id: 6411231 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E715EC0432 for ; Fri, 15 May 2015 05:24:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1217220412 for ; Fri, 15 May 2015 05:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 089CD20456 for ; Fri, 15 May 2015 05:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753986AbbEOFYD (ORCPT ); Fri, 15 May 2015 01:24:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33293 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbbEOFX7 (ORCPT ); Fri, 15 May 2015 01:23:59 -0400 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 7F54614019B; Fri, 15 May 2015 05:23:58 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 6C0AC1401A0; Fri, 15 May 2015 05:23:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kwestfie@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F257314019B; Fri, 15 May 2015 05:23:57 +0000 (UTC) Date: Thu, 14 May 2015 22:23:57 -0700 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Kenneth Westfield , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v1 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver. Message-ID: <20150515052356.GD31687@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org References: <1431518302-7139-1-git-send-email-srinivas.kandagatla@linaro.org> <1431518426-7307-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1431518426-7307-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 13, 2015 at 05:00:26AM -0700, Srinivas Kandagatla wrote: > This patch tries to make the lpass driver more generic by moving the > ipq806x specific bits out of the cpu and platform driver, also allows the > SOC specific drivers to add the correct register offsets. > > This patch also renames the register definition header file into more > generic header file. > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig > index 05b9840..865205e 100644 > --- a/sound/soc/qcom/Kconfig > +++ b/sound/soc/qcom/Kconfig > @@ -14,11 +14,16 @@ config SND_SOC_LPASS_PLATFORM > depends on SND_SOC_QCOM && OF > select REGMAP_MMIO > > +config SND_SOC_LPASS_IPQ806X > + tristate > + depends on SND_SOC_QCOM > + select SND_SOC_LPASS_CPU > + select SND_SOC_LPASS_PLATFORM Based on moving the of_device_id table from lpass-cpu.c to lpass-ipq806x.c, shouldn't the OF dependency follow to the SND_SOC_LPASS_IPQ806X config (and not SND_SOC_LPASS_CPU)? > + > config SND_SOC_STORM > tristate "ASoC I2S support for Storm boards" > depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST > - select SND_SOC_LPASS_CPU > - select SND_SOC_LPASS_PLATFORM > + select SND_SOC_LPASS_IPQ806X > select SND_SOC_MAX98357A > help > Say Y or M if you want add support for SoC audio on the > diff --git a/sound/soc/qcom/lpass-ipq806x.c > b/sound/soc/qcom/lpass-ipq806x.c > new file mode 100644 > index 0000000..d1f698c > --- /dev/null > +++ b/sound/soc/qcom/lpass-ipq806x.c > +static struct platform_driver ipq806x_lpass_cpu_platform_driver = { > + .driver = { > + .name = "lpass-cpu", > + .of_match_table = > of_match_ptr(ipq806x_lpass_cpu_device_id), > + }, > + .probe = asoc_qcom_lpass_cpu_platform_probe, > + .remove = asoc_qcom_lpass_cpu_platform_remove, > +}; > +module_platform_driver(ipq801x_lpass_cpu_platform_driver); Patch below fixes the above typo (which breaks compilation): -----------------------><--------------------------------------------- -----------------------><--------------------------------------------- > + > +MODULE_DESCRIPTION("QTi LPASS CPU Driver"); > +MODULE_LICENSE("GPL v2"); diff --git a/sound/soc/qcom/lpass-ipq806x.c b/sound/soc/qcom/lpass-ipq806x.c index ad1d67a..2eab828 100644 --- a/sound/soc/qcom/lpass-ipq806x.c +++ b/sound/soc/qcom/lpass-ipq806x.c @@ -103,7 +103,7 @@ static struct platform_driver ipq806x_lpass_cpu_platform_driver = { .probe = asoc_qcom_lpass_cpu_platform_probe, .remove = asoc_qcom_lpass_cpu_platform_remove, }; -module_platform_driver(ipq801x_lpass_cpu_platform_driver); +module_platform_driver(ipq806x_lpass_cpu_platform_driver); MODULE_DESCRIPTION("QTi LPASS CPU Driver"); MODULE_LICENSE("GPL v2");