From patchwork Mon Jan 4 17:30:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 7948851 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 04E1F9F3F6 for ; Mon, 4 Jan 2016 17:30:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3685D20142 for ; Mon, 4 Jan 2016 17:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92A5620377 for ; Mon, 4 Jan 2016 17:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbcADRaR (ORCPT ); Mon, 4 Jan 2016 12:30:17 -0500 Received: from mail1.windriver.com ([147.11.146.13]:64404 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbcADRaQ (ORCPT ); Mon, 4 Jan 2016 12:30:16 -0500 Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id u04HUDgD011526 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 4 Jan 2016 09:30:13 -0800 (PST) Received: from yow-pgortmak-d1 (128.224.56.57) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.248.2; Mon, 4 Jan 2016 09:30:13 -0800 Received: by yow-pgortmak-d1 (Postfix, from userid 1000) id CD019280143; Mon, 4 Jan 2016 12:30:12 -0500 (EST) Date: Mon, 4 Jan 2016 12:30:12 -0500 From: Paul Gortmaker To: Lina Iyer CC: , , , Subject: Re: [PATCH] drivers: qcom: spm: avoid module usage in non-modular SPM driver Message-ID: <20160104173012.GM12458@windriver.com> References: <1451927725-7257-1-git-send-email-lina.iyer@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1451927725-7257-1-git-send-email-lina.iyer@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP [[PATCH] drivers: qcom: spm: avoid module usage in non-modular SPM driver] On 04/01/2016 (Mon 10:15) Lina Iyer wrote: > SPM driver provides cpuidle support on some QC SoC's. The functionality > is non-modular and there is no need for module support. Convert module > platform init to builtin platform driver init. The driver functionality > is not affected by this change. > > Cc: Paul Gortmaker I have a similar patch locally that I'd not sent yet, the only difference is that I moved the description tag to the top of the file since there wasn't a description therei, i.e. this chunk: Paul. --- > Signed-off-by: Lina Iyer > --- > drivers/soc/qcom/spm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c > index b04b05a..199c085 100644 > --- a/drivers/soc/qcom/spm.c > +++ b/drivers/soc/qcom/spm.c > @@ -12,7 +12,6 @@ > * GNU General Public License for more details. > */ > > -#include > #include > #include > #include > @@ -378,8 +377,4 @@ static struct platform_driver spm_driver = { > .of_match_table = spm_match_table, > }, > }; > -module_platform_driver(spm_driver); > - > -MODULE_LICENSE("GPL v2"); > -MODULE_DESCRIPTION("SAW power controller driver"); > -MODULE_ALIAS("platform:saw"); > +builtin_platform_driver(spm_driver); > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c index b04b05a0904e..9e06a241257f 100644 --- a/drivers/soc/qcom/spm.c +++ b/drivers/soc/qcom/spm.c @@ -2,6 +2,8 @@ * Copyright (c) 2011-2014, The Linux Foundation. All rights reserved. * Copyright (c) 2014,2015, Linaro Ltd. * + * SAW power controller driver + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and * only version 2 as published by the Free Software Foundation.