From patchwork Wed Dec 28 22:56:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9490741 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2E4662AB0 for ; Wed, 28 Dec 2016 23:00:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF5BB26242 for ; Wed, 28 Dec 2016 23:00:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C3B5326490; Wed, 28 Dec 2016 23:00:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 699E526242 for ; Wed, 28 Dec 2016 23:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbcL1W5b (ORCPT ); Wed, 28 Dec 2016 17:57:31 -0500 Received: from mail-pg0-f41.google.com ([74.125.83.41]:36082 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbcL1W52 (ORCPT ); Wed, 28 Dec 2016 17:57:28 -0500 Received: by mail-pg0-f41.google.com with SMTP id f188so159839661pgc.3 for ; Wed, 28 Dec 2016 14:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=gLMo55WhnCh6X/hls60IPFY2TdUw1bkabbzIbKNKZe+LndB9W8prBXfabtUq9mYRh5 IsthAeHOdkPrX8ANv8RSckNWyg5ne913Yh0EghW6EpJuacHjcN5QjQaaOfqmDVX1k/QG D+Uhds7QY+R6rZFCh325K9AC8D/R3dMZbSG78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=X8Ebal3auQEnSAT6VWqTn8yPZ0eRl/F4x2l93Ji1BFgyNG81vsDBPOhFGJzUSSLozf tCuBZlw4JRgX97TcfFIJzK2iHfizLOTvtpD1fTFSP5lxUErM7o3Cj+B29wCKe6XtnDga eJ13wtSKy5xgG1clOywVTpeO/S1YLMF5kvIG0/374xQAW6vZi4BsKmD6UBz9qPqZvDfH SXatXlfzar+7sNV272EJUnytk0GWkeahJTv1J484lp5lgqM0qWn/sAD3h7nhBbGBnzOD L0AlcxkTZ1amoklKfxxIpEBB1W1xvw9JQToHrIRIL/jmROt2bQsyuSMjNJ1OiGC5NY0B fhIQ== X-Gm-Message-State: AIkVDXLpNpLUbULgsQl80l6iG1h07UpWbG0pUi6WHqmax2boRGEx8dAPiMBOmDJ5QLpKOZn3 X-Received: by 10.84.216.17 with SMTP id m17mr81253735pli.82.1482965847738; Wed, 28 Dec 2016 14:57:27 -0800 (PST) Received: from localhost.localdomain (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id x4sm100355741pgc.14.2016.12.28.14.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Dec 2016 14:57:27 -0800 (PST) From: Stephen Boyd To: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Subject: [PATCH v6 12/25] usb: chipidea: msm: Mark device as runtime pm active Date: Wed, 28 Dec 2016 14:56:58 -0800 Message-Id: <20161228225711.698-13-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.10.0.297.gf6727b0 In-Reply-To: <20161228225711.698-1-stephen.boyd@linaro.org> References: <20161228225711.698-1-stephen.boyd@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We're not properly marking the glue layer/wrapper device as runtime active, so runtime PM believes that the hardware state is inactive when we call pm_runtime_enable() in this driver. This causes a problem when the glue layer has a power domain associated with it, because runtime PM will go and disable the power domain to match the 'inactive' state of the device. Let's mark the device as active so that runtime PM doesn't improperly power down this device when it's actually active. Acked-by: Peter Chen Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 3889809fd0c4..89c1a02d69b5 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -80,6 +80,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, plat_ci); + pm_runtime_set_active(&pdev->dev); pm_runtime_no_callbacks(&pdev->dev); pm_runtime_enable(&pdev->dev);