| Message ID | 20170308141257.12119-14-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Wed, Mar 08, 2017 at 03:12:46PM +0100, Daniel Vetter wrote: > I didn't spot anything that would require ordering here (well not > anywhere else either), and I'm trying to unify at least modern drivers > on one close hook. > > Cc: Rob Clark <robdclark@gmail.com> > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> I think I've convinced myself that this is functionally equivalent (or at least if Bad Things could happen with postclose, they would also be Bad Things with preclose). So, fwiw: Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/msm/msm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 604331f3cf39..44774f02ef0e 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -540,7 +540,7 @@ static int msm_open(struct drm_device *dev, struct drm_file *file) > return 0; > } > > -static void msm_preclose(struct drm_device *dev, struct drm_file *file) > +static void msm_postclose(struct drm_device *dev, struct drm_file *file) > { > struct msm_drm_private *priv = dev->dev_private; > struct msm_file_private *ctx = file->driver_priv; > @@ -813,7 +813,7 @@ static struct drm_driver msm_driver = { > DRIVER_ATOMIC | > DRIVER_MODESET, > .open = msm_open, > - .preclose = msm_preclose, > + .postclose = msm_postclose, > .lastclose = msm_lastclose, > .irq_handler = msm_irq, > .irq_preinstall = msm_irq_preinstall, > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 604331f3cf39..44774f02ef0e 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -540,7 +540,7 @@ static int msm_open(struct drm_device *dev, struct drm_file *file) return 0; } -static void msm_preclose(struct drm_device *dev, struct drm_file *file) +static void msm_postclose(struct drm_device *dev, struct drm_file *file) { struct msm_drm_private *priv = dev->dev_private; struct msm_file_private *ctx = file->driver_priv; @@ -813,7 +813,7 @@ static struct drm_driver msm_driver = { DRIVER_ATOMIC | DRIVER_MODESET, .open = msm_open, - .preclose = msm_preclose, + .postclose = msm_postclose, .lastclose = msm_lastclose, .irq_handler = msm_irq, .irq_preinstall = msm_irq_preinstall,
I didn't spot anything that would require ordering here (well not anywhere else either), and I'm trying to unify at least modern drivers on one close hook. Cc: Rob Clark <robdclark@gmail.com> Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)