From patchwork Tue Jun 13 06:16:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenglin Wu X-Patchwork-Id: 9783217 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73DC3602DC for ; Tue, 13 Jun 2017 06:22:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 668F1284D2 for ; Tue, 13 Jun 2017 06:22:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5AFA8286E0; Tue, 13 Jun 2017 06:22:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93AFE286DB for ; Tue, 13 Jun 2017 06:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbdFMGVt (ORCPT ); Tue, 13 Jun 2017 02:21:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34248 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbdFMGVs (ORCPT ); Tue, 13 Jun 2017 02:21:48 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 125E8607E2; Tue, 13 Jun 2017 06:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497334902; bh=YccuoUuHF1YCMwi40JvqgzXeJRq8bZ+OmKTgmlVnBj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MYlzHiTwPgGJS+2TpRrKu6GJvgOTJ0F5mDlWFHXTzxDJ+ZPGLOVxgFkx1hcCWYwNs LuTTPggOCJuoO/EO53pkCkV/LfDDzNrMiNXQkH7doJ4nd4SjkSUlOubRADxOv3ghOM PYT6N8Xm760w/W/ZwJJFxNlT5UCMOQAhoPLTBbE4= Received: from FENGLINW.ap.qualcomm.com (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: fenglinw@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 99EF7607C4; Tue, 13 Jun 2017 06:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497334901; bh=YccuoUuHF1YCMwi40JvqgzXeJRq8bZ+OmKTgmlVnBj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hdUBYrHmWcx6kk4NVPakdqV9NVXBhMlIEhGwybFk1AeYK/GZI7XhP0WNCW9VqlJ32 4v/ZwZfrc1y38Ke1H8i5W4d7vyXDBWWrw4c2UYULI8miynasornAP7FEOiipZm+h7s pnSyhMxMgEGE+5yIsw2y3+lowSsIwEYye5QB5dgs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 99EF7607C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=fenglinw@codeaurora.org From: fenglinw@codeaurora.org To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , Linus Walleij , linux-soc@vger.kernel.org, linux-gpio@vger.kernel.org Cc: collinsd@quicinc.com, aghayal@qti.qualcomm.com, wruan@quicinc.com, kgunda@qti.qualcomm.com, Fenglin Wu Subject: [PATCH V1 3/3] pinctrl: qcom: spmi-gpio: Correct power_source range check Date: Tue, 13 Jun 2017 14:16:05 +0800 Message-Id: <20170613061707.13892-4-fenglinw@codeaurora.org> X-Mailer: git-send-email 2.13.0.windows.1 In-Reply-To: <20170613061707.13892-1-fenglinw@codeaurora.org> References: <20170613061707.13892-1-fenglinw@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fenglin Wu Power source selection in DIG_VIN_CTL is indexed from 0, in the range check it shouldn't be equal to the total number of power sources. Signed-off-by: Fenglin Wu Reviewed-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 581309d..1fd677c 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -500,7 +500,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin, pad->is_enabled = false; break; case PIN_CONFIG_POWER_SOURCE: - if (arg > pad->num_sources) + if (arg >= pad->num_sources) return -EINVAL; pad->power_source = arg; break;