| Message ID | 20170613130430.4272-1-robdclark@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
+cc Geert, Simon, linux-pm On Tue 13 Jun 06:04 PDT 2017, Rob Clark wrote: > In fact, it is needed for PCI to work on msm8996 (and probably other > things). No idea why it was depending on renesas but that doesn't make > any sense. So drop the dependency. > This is in line with Geert's previous comments on how to utilize simple-pm-bus to describe this hardware. Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > Signed-off-by: Rob Clark <robdclark@gmail.com> > --- > drivers/bus/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index 0a52da4..b83c535 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -121,7 +121,6 @@ config QCOM_EBI2 > config SIMPLE_PM_BUS > bool "Simple Power-Managed Bus Driver" > depends on OF && PM > - depends on ARCH_RENESAS || COMPILE_TEST > help > Driver for transparent busses that don't need a real driver, but > where the bus controller is part of a PM domain, or under the control > -- > 2.9.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Tue, Jun 13, 2017 at 3:04 PM, Rob Clark <robdclark@gmail.com> wrote: > In fact, it is needed for PCI to work on msm8996 (and probably other > things). No idea why it was depending on renesas but that doesn't make > any sense. So drop the dependency. At that time, Renesas SoCs were the only users of it. Actually at that time I wanted the functionality of simpe-pm-bus to be included in simple-bus, but the DT maintainers didn't see the merits of that. > Signed-off-by: Rob Clark <robdclark@gmail.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 13, 2017 at 09:04:30AM -0400, Rob Clark wrote: > In fact, it is needed for PCI to work on msm8996 (and probably other > things). No idea why it was depending on renesas but that doesn't make > any sense. So drop the dependency. > > Signed-off-by: Rob Clark <robdclark@gmail.com> > --- > drivers/bus/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index 0a52da4..b83c535 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -121,7 +121,6 @@ config QCOM_EBI2 > config SIMPLE_PM_BUS > bool "Simple Power-Managed Bus Driver" > depends on OF && PM > - depends on ARCH_RENESAS || COMPILE_TEST Do you really want to drop COMPILE_TEST? -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andy, On Tue, Jun 13, 2017 at 10:48 PM, Andy Gross <andy.gross@linaro.org> wrote: > On Tue, Jun 13, 2017 at 09:04:30AM -0400, Rob Clark wrote: >> In fact, it is needed for PCI to work on msm8996 (and probably other >> things). No idea why it was depending on renesas but that doesn't make >> any sense. So drop the dependency. >> >> Signed-off-by: Rob Clark <robdclark@gmail.com> >> --- >> drivers/bus/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index 0a52da4..b83c535 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -121,7 +121,6 @@ config QCOM_EBI2 >> config SIMPLE_PM_BUS >> bool "Simple Power-Managed Bus Driver" >> depends on OF && PM >> - depends on ARCH_RENESAS || COMPILE_TEST > > Do you really want to drop COMPILE_TEST? As dummies are available for all pm_*() and of_*() used by simple-pm-bus.c, I think the COMPILE_TEST can be moved one line up, i.e. depends on (OF && PM) || COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 13, 2017 at 09:39:59AM -0700, Bjorn Andersson wrote: > +cc Geert, Simon, linux-pm > > On Tue 13 Jun 06:04 PDT 2017, Rob Clark wrote: > > > In fact, it is needed for PCI to work on msm8996 (and probably other > > things). No idea why it was depending on renesas but that doesn't make > > any sense. So drop the dependency. > > > > This is in line with Geert's previous comments on how to utilize > simple-pm-bus to describe this hardware. > > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> No objection here, Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Regards, > Bjorn > > > Signed-off-by: Rob Clark <robdclark@gmail.com> > > --- > > drivers/bus/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > > index 0a52da4..b83c535 100644 > > --- a/drivers/bus/Kconfig > > +++ b/drivers/bus/Kconfig > > @@ -121,7 +121,6 @@ config QCOM_EBI2 > > config SIMPLE_PM_BUS > > bool "Simple Power-Managed Bus Driver" > > depends on OF && PM > > - depends on ARCH_RENESAS || COMPILE_TEST > > help > > Driver for transparent busses that don't need a real driver, but > > where the bus controller is part of a PM domain, or under the control > > -- > > 2.9.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 13, 2017 at 3:04 PM, Rob Clark <robdclark@gmail.com> wrote: > In fact, it is needed for PCI to work on msm8996 (and probably other > things). No idea why it was depending on renesas but that doesn't make > any sense. So drop the dependency. > > Signed-off-by: Rob Clark <robdclark@gmail.com> > --- I also couldn't find a reason why this was strictly limited, but it in the device tree sources we ship in the kernel, it is so far only used for Renesas machines, so it's not currently a bug either. Acked-by: Arnd Bergmann <arnd@arndb.de> -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index 0a52da4..b83c535 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -121,7 +121,6 @@ config QCOM_EBI2 config SIMPLE_PM_BUS bool "Simple Power-Managed Bus Driver" depends on OF && PM - depends on ARCH_RENESAS || COMPILE_TEST help Driver for transparent busses that don't need a real driver, but where the bus controller is part of a PM domain, or under the control
In fact, it is needed for PCI to work on msm8996 (and probably other things). No idea why it was depending on renesas but that doesn't make any sense. So drop the dependency. Signed-off-by: Rob Clark <robdclark@gmail.com> --- drivers/bus/Kconfig | 1 - 1 file changed, 1 deletion(-)