From patchwork Fri Jun 30 20:40:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 9820417 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E15660224 for ; Fri, 30 Jun 2017 20:40:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12B2E28511 for ; Fri, 30 Jun 2017 20:40:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06FD828478; Fri, 30 Jun 2017 20:40:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9082228478 for ; Fri, 30 Jun 2017 20:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbdF3Ukd (ORCPT ); Fri, 30 Jun 2017 16:40:33 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35312 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdF3Ukd (ORCPT ); Fri, 30 Jun 2017 16:40:33 -0400 Received: by mail-qt0-f193.google.com with SMTP id w12so16460173qta.2; Fri, 30 Jun 2017 13:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=7eKu3ptWGKe0AGWwg1m5LTMcV6N3eywScritx8ZtNhE=; b=mIwgrumx319LikwD0eN/LqOhzTS/YhUUHGidRZW7cx4XNMujzz7Lw3RXPdDFFk/Qr9 T2LemhdsgbWAWh/O3IGE0V2j7jw6Nu63jMNi2Z8h38I3gTkU5S/GEUMdkKFz8wiChsgV 9aaSPXCXoQ5Xz/8iXoRuv3sXgxu3DKaObhPTQB4VN+GqU5Zj8lp2a/g4TjVOUimA+ywg VrJbGlKSTM4vHWtOR5I1nPKACYrLrHpz8wmwEv+Dru2m0IhMTIs/HmbG+lVI3Mo1AnkG 0BP3amX/B196TQcLENwGaWmhTrPFXjYR2ux/ccdtyagS0OTu58m0JLpfdtefjpvaC48p +zRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7eKu3ptWGKe0AGWwg1m5LTMcV6N3eywScritx8ZtNhE=; b=ox4Mm0EaU6tJo+l2O2isE43IsX7ZC/keQm7Tb5igIPxcHDyjQvlqIIgmbK83hV3i0H OES/SYzKbBchCnqIO8daLPkKQCuJLJFm/JKa9IOAzM2f7j4KwyKc7HO5pYa6FEGcPZpP 3jsyOTVfiK4ZYf8ng5ZTla3qMkgZSNUjGTeVe1NDznxZfM+i43dc8oh8C7EKa2IdPlA4 joECTBQ9QxBiACrG+9ZhAgOfA11NBQ8oAhzkk7Y802/i75wy46XLSqk+3r81Ksw6r+DU si5Elnt630brEXYBT8kctPitdZyR7lRuynKBGPYr8OlDUj80/X5vHyoxz98jWg+uwwuz TAzA== X-Gm-Message-State: AKS2vOzlkpaclf2bPuIKq52sp0sSbOuX0LXPe/MwyNTMPY885LzkTvjt 3/pvfA80DVXinWOtAnk= X-Received: by 10.200.47.176 with SMTP id l45mr28537505qta.153.1498855231731; Fri, 30 Jun 2017 13:40:31 -0700 (PDT) Received: from localhost ([144.121.20.162]) by smtp.gmail.com with ESMTPSA id s6sm6797024qki.44.2017.06.30.13.40.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Jun 2017 13:40:30 -0700 (PDT) From: Rob Clark To: linux-arm-msm@vger.kernel.org Cc: Rajendra Nayak , Bjorn Andersson , Rob Clark , stable@vger.kernel.org Subject: [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init Date: Fri, 30 Jun 2017 16:40:23 -0400 Message-Id: <20170630204023.31712-1-robdclark@gmail.com> X-Mailer: git-send-email 2.9.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP init_common() is called from probe, which can happen after the __init section is already unloaded in the case of -EPROBE_DEFER. Causing a later probe to attempt to branch to hyperspace. Cc: Signed-off-by: Rob Clark Acked-by: Bjorn Andersson Acked-by: Rajendra Nayak --- drivers/thermal/qcom/tsens-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index b1449ad..22ad37c 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -123,7 +123,7 @@ static const struct regmap_config tsens_config = { .reg_stride = 4, }; -int __init init_common(struct tsens_device *tmdev) +int init_common(struct tsens_device *tmdev) { void __iomem *base;