diff mbox

ARM64: DT: add 'ranges' to chosen node

Message ID 20170710191827.14271-1-robdclark@gmail.com (mailing list archive)
State Deferred
Delegated to: Andy Gross
Headers show

Commit Message

Rob Clark July 10, 2017, 7:18 p.m. UTC
Some LK's can populate chosen with a simple-framebuffer node to hand
over bootloader display to kernel (or u-boot/etc).  But kernel fails to
grok it properly without knowing address/size size.

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Clark July 10, 2017, 8:22 p.m. UTC | #1
On Mon, Jul 10, 2017 at 3:18 PM, Rob Clark <robdclark@gmail.com> wrote:
> Some LK's can populate chosen with a simple-framebuffer node to hand
> over bootloader display to kernel (or u-boot/etc).  But kernel fails to
> grok it properly without knowing address/size size.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 56549063396f..5c36a0934989 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -30,7 +30,9 @@
>                 sdhc2 = &sdhc_2; /* SDC2 SD card slot */
>         };
>
> -       chosen { };
> +       chosen {
> +               ranges;

just chatting about this on IRC.. and I think we should also have

  #address-cells = <1>;
  #size-cells = <1>;

too.. since display controller (unless you take iommu out of bypass..
which isn't going to happen in bootloader or early kernel) can only
address lower 32b of address space..

BR,
-R

> +       };
>
>         memory {
>                 device_type = "memory";
> --
> 2.13.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 56549063396f..5c36a0934989 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -30,7 +30,9 @@ 
 		sdhc2 = &sdhc_2; /* SDC2 SD card slot */
 	};
 
-	chosen { };
+	chosen {
+		ranges;
+	};
 
 	memory {
 		device_type = "memory";