From patchwork Mon Aug 28 03:00:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenglin Wu X-Patchwork-Id: 9924079 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 204C460329 for ; Mon, 28 Aug 2017 03:03:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 123292863D for ; Mon, 28 Aug 2017 03:03:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06F3628616; Mon, 28 Aug 2017 03:03:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CABA28610 for ; Mon, 28 Aug 2017 03:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdH1DDL (ORCPT ); Sun, 27 Aug 2017 23:03:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45694 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdH1DDK (ORCPT ); Sun, 27 Aug 2017 23:03:10 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2075160724; Mon, 28 Aug 2017 03:03:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503889390; bh=V3RMGnfwfU64wOOGjn/0Lw+IYnqThPvYQhFenaAr8yA=; h=From:To:Cc:Subject:Date:From; b=L1Fn4+W/17pz9Yxt9/ot4qKQV7WrHlqYje/p8dr+8ERMmvxB+eB+FcdQCl3VfeC97 nkv9Uqi4PZjggnQXjIo2NUWysuKoEuacXf2QoazKpvR62SVGoCQq6nDXm6NVzoaHlL x2aFFgOgc025BtqtVZiWpOFgg2b+11C4y9NwUgTw= Received: from FENGLINW.ap.qualcomm.com (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: fenglinw@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3D0E160718; Mon, 28 Aug 2017 03:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503889389; bh=V3RMGnfwfU64wOOGjn/0Lw+IYnqThPvYQhFenaAr8yA=; h=From:To:Cc:Subject:Date:From; b=RGEYorj7LCfUVSjw3Z+1z0ML3S353O9fDZcDo0ZDXQq7/RRGrXAeeGuV4De7Y4Hnb s8+TEqhHJkp6FwYv0SK2dsmQYVgQZKGzJXGuyv9tPaRnpedPeZkQzlzgK07eYXCFD2 CDk8JSewxstYe/z2t/KU4UiWfRcM+3YsYRNqG890= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3D0E160718 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=fenglinw@codeaurora.org From: fenglinw@codeaurora.org To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, Linus Walleij , linux-gpio@vger.kernel.org Cc: collinsd@codeaurora.org, aghayal@codeaurora.org, wruan@codeaurora.org, kgunda@codeaurora.org, Fenglin Wu Subject: [PATCH V2] pinctrl: qcom: spmi-gpio: Correct power_source range check Date: Mon, 28 Aug 2017 11:00:42 +0800 Message-Id: <20170828030227.16796-1-fenglinw@codeaurora.org> X-Mailer: git-send-email 2.13.0.windows.1 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fenglin Wu Power source selection in DIG_VIN_CTL is indexed from 0, in the range check it shouldn't be equal to the total number of power sources. Signed-off-by: Fenglin Wu Acked-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 664b641..8b77c04 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -375,7 +375,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin, pad->is_enabled = false; break; case PIN_CONFIG_POWER_SOURCE: - if (arg > pad->num_sources) + if (arg >= pad->num_sources) return -EINVAL; pad->power_source = arg; break;