From patchwork Fri Oct 6 10:57:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Archit Taneja X-Patchwork-Id: 9988985 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10FCE60247 for ; Fri, 6 Oct 2017 10:57:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01CC728599 for ; Fri, 6 Oct 2017 10:57:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB0CA28C9B; Fri, 6 Oct 2017 10:57:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DE3428599 for ; Fri, 6 Oct 2017 10:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdJFK5T (ORCPT ); Fri, 6 Oct 2017 06:57:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47844 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbdJFK5S (ORCPT ); Fri, 6 Oct 2017 06:57:18 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2F28F60A17; Fri, 6 Oct 2017 10:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507287438; bh=ZNMB9xDmIYLEze8GwTA/6ZAadO61pKJz7ixABDhny90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S34c82v1g0sOljWd4aSV+TQEvlNrBOFR5ekZWhiuskoh6rG3WkVlcf69CBgWjjZmi kxssXttpCQoBbbWTxTSsdZn8gojU2Ivn3EX6FU3xaynG5MYTlSTC6FzKX5hc6YwOCH Q45lyEmPFLpszI6VASevARGG3dheCX47drE7ukFE= Received: from localhost (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: architt@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 21C46601D7; Fri, 6 Oct 2017 10:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507287437; bh=ZNMB9xDmIYLEze8GwTA/6ZAadO61pKJz7ixABDhny90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NS+4sUP8Tx2hRuhlrB/+anrPA0qn8zbC730vSgnzn6AH97l0/KyA0hm7gkU/OO70K IkZhriffUKDEAfvUHxsdeDRKXCGYtfCy/N74Jk79JpiDEUzMnqGo7oXNsFB+M/gEyd Yzf65TMivvmZigbVHF3kJDlvVPPx4u+XJpl5KYqY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 21C46601D7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org From: Archit Taneja To: robdclark@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Archit Taneja Subject: [PATCH 2/2] drm/msm/mdp5: Remove extra pm_runtime_put call in mdp5_crtc_cursor_set() Date: Fri, 6 Oct 2017 16:27:07 +0530 Message-Id: <20171006105707.20416-3-architt@codeaurora.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20171006105707.20416-1-architt@codeaurora.org> References: <20171006105707.20416-1-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While converting mdp5_enable/disable() calls to pm_runtime_get/put() API, an extra call to pm_runtime_put_autosuspend() crept in mdp5_crtc_cursor_set(). This results in calling the suspend handler twice, and therefore clk_disables twice, which isn't a nice thing to do. Fixes: d68fe15b1878 (drm/msm/mdp5: Use runtime PM get/put API instead ...) Reported-by: Stanimir Varbanov Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c index 6fcb58ab718c..440977677001 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c @@ -804,8 +804,6 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc, spin_unlock_irqrestore(&mdp5_crtc->cursor.lock, flags); - pm_runtime_put_autosuspend(&pdev->dev); - set_cursor: ret = mdp5_ctl_set_cursor(ctl, pipeline, 0, cursor_enable); if (ret) {