From patchwork Fri Jan 5 17:09:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10146797 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4C599601A1 for ; Fri, 5 Jan 2018 17:10:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 30F312846F for ; Fri, 5 Jan 2018 17:10:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 24DBE286FF; Fri, 5 Jan 2018 17:10:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A27CC2846F for ; Fri, 5 Jan 2018 17:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbeAERKK (ORCPT ); Fri, 5 Jan 2018 12:10:10 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35229 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752347AbeAERKH (ORCPT ); Fri, 5 Jan 2018 12:10:07 -0500 Received: by mail-wr0-f196.google.com with SMTP id l19so4887148wrc.2 for ; Fri, 05 Jan 2018 09:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SvqmIi4JX7FUmE1hctK4hcawSrjR038rkKJJ0LAXBHw=; b=rpdkbKFV7OSY+NTAq2vYFxIO+IdC+twvL2JGL4p+mqJmWmoQhcPHnBsDs7R5Kf2k+1 dh5emdwbUh/eHCIorUVQcfx9e2dmBr9PxaK4vVNPDkB5lzYBEg9/7HX/wjQ/PoSjttiN Y/FwY4pvbiH0zg0lhU5+53eSIRxCU5eNPsQyl0fYYjG9C+f8BpeYzd9wdHj/cObdk4jB 50m2u3Pq2dpEiQNvhcn4RHx7X1MgFWk59klHPN7sU1z1LQXZS3k6O54/pB1JjkWz66xT MBYPCyB4oc6dJzinWUTdgwQN0L2BqL/pYBMiFUJ7ZY8k1xLb78xqv1399PdjDa2kUxnz LyNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SvqmIi4JX7FUmE1hctK4hcawSrjR038rkKJJ0LAXBHw=; b=iOT65SV3Cb7xVErdm+hkLnboD2IUq7ps1n5+LvGN4mg1EFi/uMSfVxCeABlB4XElr4 W87HG1oxRgt/7TjcfB+DiUd5EfSh0Oj0w3gFtWLc9KUcJdBoHzdhKZ/oLoFkxeHACgrr iKAPcR4tK2Z7Lh8vl/qEDApCMTfQ7E3lMY7xEKfYZDqRBK1W7B7Q6vQqLzl4cf+8XHEx fgNHS22H/xtc93cyuFyNCxqEO7B8ibVfZaioulHFs/oRVjx2ntLOXQWgrZM+SQqVGh1w lr/a0WXfZbAsoijI0QuTnRTtong6Et11lPk3pNU5e3X9Rnzd8TfXHi0iwoXpll1Ve+AJ l3dA== X-Gm-Message-State: AKGB3mLOvTU42lkuet4qxB1imlil8LoC8rP6Gx0TuAXFLctxRnAonfJT IePuoQ+Yln9XDLPoqYJzfLXF1Cdg X-Google-Smtp-Source: ACJfBouRKCRpQKvMZFx0esiS0ie1zf8uP0RIn6NkeWBDkw8fVQIzmsVyggSHEyZk+XkCDmIviAvPxA== X-Received: by 10.223.190.18 with SMTP id n18mr3369519wrh.108.1515172205508; Fri, 05 Jan 2018 09:10:05 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id g17sm3263661wra.6.2018.01.05.09.10.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jan 2018 09:10:04 -0800 (PST) From: Jerome Brunet To: Stephen Boyd , Michael Turquette , linux-clk@vger.kernel.org Cc: Jerome Brunet , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Vladimir Zapolskiy , Sylvain Lemieux , Andy Gross , David Brown Subject: [PATCH 2/5] clk: lpc32xx: read-only divider can propagate rate change Date: Fri, 5 Jan 2018 18:09:56 +0100 Message-Id: <20180105170959.17266-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180105170959.17266-1-jbrunet@baylibre.com> References: <20180105170959.17266-1-jbrunet@baylibre.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When a divider clock has CLK_DIVIDER_READ_ONLY set, it means that the register shall be left un-touched, but it does not mean the clock should stop rate propagation if CLK_SET_RATE_PARENT is set This properly handled in qcom clk-regmap-divider but it was not in the lpc32xx divider Fixes: f7c82a60ba26 ("clk: lpc32xx: add common clock framework driver") Signed-off-by: Jerome Brunet --- drivers/clk/nxp/clk-lpc32xx.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index f5d815f577e0..729333766f97 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -963,6 +963,7 @@ static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *prate) { struct lpc32xx_clk_div *divider = to_lpc32xx_div(hw); + struct clk_hw *hw_parent = clk_hw_get_parent(hw); unsigned int bestdiv; /* if read only, just return current value */ @@ -972,6 +973,15 @@ static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, bestdiv &= div_mask(divider->width); bestdiv = _get_div(divider->table, bestdiv, divider->flags, divider->width); + + /* Even a read-only clock can propagate a rate change */ + if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) { + if (!hw_parent) + return -EINVAL; + + *prate = clk_hw_round_rate(hw_parent, rate * bestdiv); + } + return DIV_ROUND_UP(*prate, bestdiv); }