From patchwork Mon Feb 26 09:49:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10241807 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A7273602DC for ; Mon, 26 Feb 2018 09:49:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94D7E29A98 for ; Mon, 26 Feb 2018 09:49:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 893D929ECE; Mon, 26 Feb 2018 09:49:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27B9129A98 for ; Mon, 26 Feb 2018 09:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbeBZJtv (ORCPT ); Mon, 26 Feb 2018 04:49:51 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:37659 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbeBZJtu (ORCPT ); Mon, 26 Feb 2018 04:49:50 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MhrpH-1f2XV04Bwx-00MuKR; Mon, 26 Feb 2018 10:49:42 +0100 From: Arnd Bergmann To: Rob Clark , Jordan Crouse Cc: Arnd Bergmann , David Airlie , Nicolas Dechesne , Archit Taneja , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/msm: fix building without debugfs Date: Mon, 26 Feb 2018 10:49:26 +0100 Message-Id: <20180226094941.2783405-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:kkfEgG/0yDhC6Ll1DSQYMwQSd2hVPBgQve1rK8+WNb9L2bn036O 7ZaWW+T5I7J/1JnhrnWYaVOc8dcaF/yb4+NYIosfZyEqK5AP8oJq3Rxh13GKGDiUuczkCmJ irXH5FkOhDrtaR3TzI+Sa5JuWiWSiAsJsfaTIwkcuBuNHxIq0i49aDLdBo7hXexdbThklCk OLEEutuxGBR0a4EArrueg== X-UI-Out-Filterresults: notjunk:1; V01:K0:IgcO1iWzomg=:dWle4ckDBmPdeSy2QqCW3i kLzfIHc5I/B4mu85XQi4pydmfwv5VPb+XlCFQsgGrQJN7Vk1FlpMSx5pPZ/wITKF6wwzTf4dQ hvwJANmI6zVpVSsgld5RXr0iyf/GQXpkOaFunfcCaWh9W6dmW9rHze3K4lWzpqiKXF3dc+Kw+ Si9hRI0P6ini8EP1VeVegnKJFUCCc2Kjv3cbPUfR0C+HXdHMFhN5cGnSG4FLt59qEjfKvTUpa rKIPrh8Z2pAHJ0qbGyKp+uyjTrXZmHdGfqrjbEbfCnctElsHHHl1oRVYo5Na1/pImYmTv/mJR 5WpMq3BFSOGg94BLqRJSV2yoA2ZJQa1TB38TaG9VhUoQyMkLbPQevZfgmMBEEC5Gi0uO/WOal kH4Q3i88SlnEPwmAcTTJ08bANrhJdJwd//nuFBTt/zmmknE4RvH/qRxJyCwAnDoVRsGUoSkLJ TAs2U5rFM1afsie9pscpAlaXT0ApCSikoGhcjK6x3uL3MM9qFM7mJjCAySXDbSiw1w/qPhmdv 7hcnbcpaW0K1Ab5JKNLBawalXAKkTySBUOJtm2ChRj09aFjwQaFVeXoP+OMrhBz9IB6mPmh9R kSzSbuVCFFtgbrEHj+SSjvwX+8V+kJtLNurRCWuiKH2yIEUnq+NRIygajLigIJ4sUnwp0igF2 vED7mUmluR3MOf+Dj7/OqYzVDepTzjuUOj8clmJvXkZ27ehmUFb3CNY2qEdNM8esU8vPzDfpk 19hW5QApHRluSB/pktfN9fcIth3H50qTFgfumg== Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The adreno driver stopped building when CONFIG_DEBUGFS is disabled: drivers/gpu/drm/msm/adreno/adreno_device.c: In function 'adreno_load_gpu': drivers/gpu/drm/msm/adreno/adreno_device.c:153:16: error: 'const struct msm_gpu_funcs' has no member named 'debugfs_init' if (gpu->funcs->debugfs_init) { ^~ drivers/gpu/drm/msm/adreno/adreno_device.c:154:13: error: 'const struct msm_gpu_funcs' has no member named 'debugfs_init' gpu->funcs->debugfs_init(gpu, dev->primary); ^~ This adds an #ifdef around the code that references the hidden pointer. Fixes: 331dc0bc195b ("drm/msm: add a5xx specific debugfs") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index f07d3ec7d77b..8e0cb161754b 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -164,11 +164,13 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) return NULL; } +#ifdef CONFIG_DEBUG_FS if (gpu->funcs->debugfs_init) { gpu->funcs->debugfs_init(gpu, dev->primary); gpu->funcs->debugfs_init(gpu, dev->render); gpu->funcs->debugfs_init(gpu, dev->control); } +#endif return gpu; }