| Message ID | 20180316040824.21472-6-rnayak@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 16-03-18, 09:38, Rajendra Nayak wrote: > Add rpmpd device node and its OPP table > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 46 +++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 0a6f7952bbb1..43757a078146 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -297,6 +297,52 @@ > #clock-cells = <1>; > }; > > + rpmpd: qcom,rpmpd { > + compatible = "qcom,rpmpd-msm8996"; > + #power-domain-cells = <1>; > + operating-points-v2 = <&rpmpd_opp_table>, /* cx */ > + <&rpmpd_opp_table>, /* cx_ao */ > + <&rpmpd_opp_table>, /* cx_vfc */ > + <&rpmpd_opp_table>, /* mx */ > + <&rpmpd_opp_table>, /* mx_ao */ > + <&rpmpd_opp_table>, /* sscx */ > + <&rpmpd_opp_table>; /* sscx_vfc */ > + }; > + > + rpmpd_opp_table: opp-table { > + compatible = "operating-points-v2", "operating-points-v2-qcom"; > + > + rpmpd_opp1: opp@1 { > + opp-hz = /bits/ 64 <1>; Actually this (magic values) isn't allowed right now. I will send a patchset to make this property optional later on separately (once the other series is accepted). > + qcom,level = <1>; > + }; > + > + rpmpd_opp2: opp@2 { > + opp-hz = /bits/ 64 <2>; > + qcom,level = <2>; > + }; > + > + rpmpd_opp3: opp@3 { > + opp-hz = /bits/ 64 <3>; > + qcom,level = <3>; > + }; > + > + rpmpd_opp4: opp@4 { > + opp-hz = /bits/ 64 <4>; > + qcom,level = <4>; > + }; > + > + rpmpd_opp5: opp@5 { > + opp-hz = /bits/ 64 <5>; > + qcom,level = <5>; > + }; > + > + rpmpd_opp6: opp@6 { > + opp-hz = /bits/ 64 <6>; > + qcom,level = <6>; > + }; > + }; > + > pm8994-regulators { > compatible = "qcom,rpm-pm8994-regulators"; > Everything else is fine. After you remove the opp-hz property from this table: Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Quoting Rajendra Nayak (2018-03-15 21:08:22) > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 0a6f7952bbb1..43757a078146 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -297,6 +297,52 @@ > #clock-cells = <1>; > }; > > + rpmpd: qcom,rpmpd { power-controller? power-domain-controller? power-domains? Or something like that. > + compatible = "qcom,rpmpd-msm8996"; > + #power-domain-cells = <1>; > + operating-points-v2 = <&rpmpd_opp_table>, /* cx */ > + <&rpmpd_opp_table>, /* cx_ao */ > + <&rpmpd_opp_table>, /* cx_vfc */ > + <&rpmpd_opp_table>, /* mx */ > + <&rpmpd_opp_table>, /* mx_ao */ > + <&rpmpd_opp_table>, /* sscx */ > + <&rpmpd_opp_table>; /* sscx_vfc */ > + }; > + > + rpmpd_opp_table: opp-table { This should go into the root of the tree? Otherwise it may be populated by the RPMh platform populate code which would be odd. We should go and update the platform populate code to always ignore operating-points-v2 compatible nodes too. > + compatible = "operating-points-v2", "operating-points-v2-qcom"; This is backwards? I thought more specific compatible went first. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09-04-18, 09:03, Stephen Boyd wrote: > We should go and > update the platform populate code to always ignore operating-points-v2 > compatible nodes too. Will do that.
On 04/09/2018 09:33 PM, Stephen Boyd wrote: > Quoting Rajendra Nayak (2018-03-15 21:08:22) >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 0a6f7952bbb1..43757a078146 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -297,6 +297,52 @@ >> #clock-cells = <1>; >> }; >> >> + rpmpd: qcom,rpmpd { > > power-controller? power-domain-controller? power-domains? Or something > like that. > >> + compatible = "qcom,rpmpd-msm8996"; >> + #power-domain-cells = <1>; >> + operating-points-v2 = <&rpmpd_opp_table>, /* cx */ >> + <&rpmpd_opp_table>, /* cx_ao */ >> + <&rpmpd_opp_table>, /* cx_vfc */ >> + <&rpmpd_opp_table>, /* mx */ >> + <&rpmpd_opp_table>, /* mx_ao */ >> + <&rpmpd_opp_table>, /* sscx */ >> + <&rpmpd_opp_table>; /* sscx_vfc */ >> + }; >> + >> + rpmpd_opp_table: opp-table { > > This should go into the root of the tree? Otherwise it may be populated > by the RPMh platform populate code which would be odd. We should go and > update the platform populate code to always ignore operating-points-v2 > compatible nodes too. > >> + compatible = "operating-points-v2", "operating-points-v2-qcom"; > > This is backwards? I thought more specific compatible went first. thanks for the review, will fixup all of these when I respin.
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 0a6f7952bbb1..43757a078146 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -297,6 +297,52 @@ #clock-cells = <1>; }; + rpmpd: qcom,rpmpd { + compatible = "qcom,rpmpd-msm8996"; + #power-domain-cells = <1>; + operating-points-v2 = <&rpmpd_opp_table>, /* cx */ + <&rpmpd_opp_table>, /* cx_ao */ + <&rpmpd_opp_table>, /* cx_vfc */ + <&rpmpd_opp_table>, /* mx */ + <&rpmpd_opp_table>, /* mx_ao */ + <&rpmpd_opp_table>, /* sscx */ + <&rpmpd_opp_table>; /* sscx_vfc */ + }; + + rpmpd_opp_table: opp-table { + compatible = "operating-points-v2", "operating-points-v2-qcom"; + + rpmpd_opp1: opp@1 { + opp-hz = /bits/ 64 <1>; + qcom,level = <1>; + }; + + rpmpd_opp2: opp@2 { + opp-hz = /bits/ 64 <2>; + qcom,level = <2>; + }; + + rpmpd_opp3: opp@3 { + opp-hz = /bits/ 64 <3>; + qcom,level = <3>; + }; + + rpmpd_opp4: opp@4 { + opp-hz = /bits/ 64 <4>; + qcom,level = <4>; + }; + + rpmpd_opp5: opp@5 { + opp-hz = /bits/ 64 <5>; + qcom,level = <5>; + }; + + rpmpd_opp6: opp@6 { + opp-hz = /bits/ 64 <6>; + qcom,level = <6>; + }; + }; + pm8994-regulators { compatible = "qcom,rpm-pm8994-regulators";