From patchwork Thu May 17 16:03:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10407071 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C948D60247 for ; Thu, 17 May 2018 16:06:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9233285C9 for ; Thu, 17 May 2018 16:06:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADB6D285D3; Thu, 17 May 2018 16:06:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E7EF285C9 for ; Thu, 17 May 2018 16:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbeEQQGI (ORCPT ); Thu, 17 May 2018 12:06:08 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54484 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbeEQQGG (ORCPT ); Thu, 17 May 2018 12:06:06 -0400 Received: by mail-wm0-f66.google.com with SMTP id f6-v6so9386996wmc.4 for ; Thu, 17 May 2018 09:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=OgQDfJUVW+e559D9Y2nidPGoExRN1sz+bU/oeKRbGWk=; b=B/EQRT0H91UJM853j3PFAw/MYbfX7Ggq6qgclmrbQeIIKjogDsqafKyYaDxCxXfdQD 2vdCg/hUJCa7OPz09YgG2G7c1W2W+mm73HsqEqIkyzyZ59sc+h8sZGa9rfwgsvV7ybND V02FCDbm9E9N8HAELbW5nJ35pCSLDWyKzg6mE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OgQDfJUVW+e559D9Y2nidPGoExRN1sz+bU/oeKRbGWk=; b=p87w5XS9bBbXoPZ5CYB8TqALLCyErPcDoHrMaTBmU9OkyCz+TFXTrzFX54qbxgQasD /BDymunNzL98px5EfN+Eg9zYSw2qF+7z0dBZh17rM656ZIytZNfe5HiAsXf6KPz4q9RJ AfV6SuQcpSosetPNqMOrqWnXj54670WJ54t/P12WdWmSLvAh0RcDU61gwD62btsiQgXa PcGyLZXANf1A3oI9bgOKjvRyMYVbUa6CXKuT2PbsBRKTll/LTusqDQF9WXJbgbHkR53Z ZxcWb3Z+HDolqDxBxvDPZkAAgT4/HSOn4bFxlsKUr09GA3mC8SdB+K8Hu0kSAzYVGx/3 LAwQ== X-Gm-Message-State: ALKqPwefxKiHFoq+hKdFz+Zp2Jqmr01mlFSx7EMgEnCgWnlYF89XSEnF 4JLhJvyQkI3Z/GTnB9Q9PLxlng== X-Google-Smtp-Source: AB8JxZqkd7VlUNRvgg3zpKZ16Q/3dUfJcHDXk2A4HsU8c3O91TApC4u2S+zMTKEFcGtxwwI+SQ4lAA== X-Received: by 2002:a1c:5b02:: with SMTP id p2-v6mr2228945wmb.20.1526573165472; Thu, 17 May 2018 09:06:05 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id c50-v6sm9254734wrc.11.2018.05.17.09.06.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 May 2018 09:06:04 -0700 (PDT) From: Srinivas Kandagatla To: agross@codeaurora.org, broonie@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Srinivas Kandagatla Subject: [PATCH] soc: qcom: apr: fix invalid msg_type check Date: Thu, 17 May 2018 17:03:53 +0100 Message-Id: <20180517160353.27561-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Removed invalid msg_type check. This also fixes below static checker warning: apr.c:95:35: warning: comparison is always true due to limited range of data type [-Wtype-limits] warn: always true condition '(msg_type != 69864) => (0-u16max != 69864)' Reported-by: Dan Carpenter Signed-off-by: Srinivas Kandagatla --- drivers/soc/qcom/apr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 97f3622da535..57af8a537332 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -92,7 +92,7 @@ static int apr_callback(struct rpmsg_device *rpdev, void *buf, } msg_type = APR_HDR_FIELD_MT(hdr->hdr_field); - if (msg_type >= APR_MSG_TYPE_MAX && msg_type != APR_BASIC_RSP_RESULT) { + if (msg_type >= APR_MSG_TYPE_MAX) { dev_err(apr->dev, "APR: Wrong message type: %d\n", msg_type); return -EINVAL; }