From patchwork Mon Jun 18 12:33:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10471233 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 255446020C for ; Mon, 18 Jun 2018 12:34:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 159CA289BC for ; Mon, 18 Jun 2018 12:34:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A482289C0; Mon, 18 Jun 2018 12:34:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBA1F289BC for ; Mon, 18 Jun 2018 12:34:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbeFRMe0 (ORCPT ); Mon, 18 Jun 2018 08:34:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39245 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754321AbeFRMeJ (ORCPT ); Mon, 18 Jun 2018 08:34:09 -0400 Received: by mail-wm0-f68.google.com with SMTP id p11-v6so15238665wmc.4 for ; Mon, 18 Jun 2018 05:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Vx8TlFkg5GYV7lFQXfNT+lRC4bhizL4OBcbu8QAXzh4=; b=abvWTwWXzTxST3/NnXfsa/MmUSDa25WbwGyx8fGbv7Dj1D6kKx+0vdPgUI8mFWOc4c tQGK2wnm1EGle5HRdeS++DhXchUkFtOpdsi7Z7zM+97fvHafCWguuWInWFtcVR4CrHKC mSVgnUJMKwhVSU7LD9OqGc4LK1me9NZG7P5OI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Vx8TlFkg5GYV7lFQXfNT+lRC4bhizL4OBcbu8QAXzh4=; b=j6/dnK6jOIcLjeYxcHyTmxxenDVfEuvEGFKFxyyHvvtJxsD8y462RztTQnJpaNk+Th 4WE/+zVt/ciFjlo0222HjsxcQVdx4aZujzjTZwENH0eOcILMmWbisKkuekzLIAxEB0R0 r36mqwdaQCvVoZqWx7ZXgZXcomqcFa8C3xCsWZ18ONmFEK2FGiB/rl/2myTyWCImkyOW 3s5al6D7LH7pPak9bZdFFfWs6/Tw5tQtOT9SUUsiUJSwJkVkLRyJOLLBCXvw5zBOpL8k DcRuoe5q/F9PuM2j1MO9myLECLFXkuIQcyU6ihluvQP+5EtKx4qu4Y9Pq3EGkt8LcBbw kBlQ== X-Gm-Message-State: APt69E3Lbk+vco6+JC/2Yj5T8m6bhX/sa9OVHy6FGZR69mvyIlrdzWbS omwr4xZH5a5iA/oTPgLOk3efxQ== X-Google-Smtp-Source: ADUXVKIuea6gwuBUJovq6AnEahbmJIZRzmTqHXTihYiGimVbxKf/9VrnLfXJyP1dW8MMpOwhEAMnbQ== X-Received: by 2002:a1c:e0c6:: with SMTP id x189-v6mr9088535wmg.52.1529325248046; Mon, 18 Jun 2018 05:34:08 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id r10-v6sm24291318wrm.66.2018.06.18.05.34.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jun 2018 05:34:07 -0700 (PDT) From: Srinivas Kandagatla To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 3/3] rpmsg: smd: fix kerneldoc warnings Date: Mon, 18 Jun 2018 13:33:39 +0100 Message-Id: <20180618123339.24115-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180618123339.24115-1-srinivas.kandagatla@linaro.org> References: <20180618123339.24115-1-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes below kerneldoc warnings qcom_smd.c:141: warning: Function parameter or member 'dev' not described in 'qcom_smd_edge' qcom_smd.c:141: warning: Function parameter or member 'name' not described in 'qcom_smd_edge' qcom_smd.c:141: warning: Function parameter or member 'new_channel_event' not described in 'qcom_smd_edge' qcom_smd.c:222: warning: Function parameter or member 'qsept' not described in 'qcom_smd_channel' qcom_smd.c:222: warning: Function parameter or member 'registered' not described in 'qcom_smd_channel' qcom_smd.c:222: warning: Function parameter or member 'state_change_event' not described in 'qcom_smd_channel' qcom_smd.c:222: warning: Function parameter or member 'drvdata' not described in 'qcom_smd_channel' qcom_smd.c:737: warning: Function parameter or member 'wait' not described in '__qcom_smd_send' Signed-off-by: Srinivas Kandagatla qcom_smd.c --- drivers/rpmsg/qcom_smd.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 6437bbeebc91..8c6a142050f8 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -93,6 +93,8 @@ static const struct { /** * struct qcom_smd_edge - representing a remote processor + * @dev: device associated with this edge + * @name: name of this edge * @of_node: of_node handle for information related to this edge * @edge_id: identifier of this edge * @remote_pid: identifier of remote processor @@ -106,6 +108,7 @@ static const struct { * @channels_lock: guard for modifications of @channels * @allocated: array of bitmaps representing already allocated channels * @smem_available: last available amount of smem triggering a channel scan + * @new_channel_event: wait queue for new channel events * @scan_work: work item for discovering new channels * @state_work: work item for edge state changes */ @@ -172,10 +175,12 @@ struct qcom_smd_endpoint { /** * struct qcom_smd_channel - smd channel struct * @edge: qcom_smd_edge this channel is living on - * @qsdev: reference to a associated smd client device + * @qsept: reference to a associated smd endpoint + * @registered: flag to indicate if the channel is registered * @name: name of the channel * @state: local state of the channel * @remote_state: remote state of the channel + * @state_change_event: state change event * @info: byte aligned outgoing/incoming channel info * @info_word: word aligned outgoing/incoming channel info * @tx_lock: lock to make writes to the channel mutually exclusive @@ -187,6 +192,7 @@ struct qcom_smd_endpoint { * @cb: callback function registered for this channel * @recv_lock: guard for rx info modifications and cb pointer * @pkt_size: size of the currently handled packet + * @drvdata: driver private data * @list: lite entry for @channels in qcom_smd_edge */ struct qcom_smd_channel { @@ -726,6 +732,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel, * @channel: channel handle * @data: buffer of data to write * @len: number of bytes to write + * @wait: flag to indicate if write has ca wait * * This is a blocking write of len bytes into the channel's tx ring buffer and * signal the remote end. It will sleep until there is enough space available