From patchwork Wed Jun 20 20:48:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10478709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 072D360230 for ; Wed, 20 Jun 2018 20:48:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECF1E28355 for ; Wed, 20 Jun 2018 20:48:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1911283A5; Wed, 20 Jun 2018 20:48:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9663828355 for ; Wed, 20 Jun 2018 20:48:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933285AbeFTUsy (ORCPT ); Wed, 20 Jun 2018 16:48:54 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35412 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933283AbeFTUsy (ORCPT ); Wed, 20 Jun 2018 16:48:54 -0400 Received: by mail-yw0-f195.google.com with SMTP id v131-v6so348061ywg.2 for ; Wed, 20 Jun 2018 13:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KaIdwrCkpiQm7QmH7kGEIFHkiXaTx0GXyebKeCAhIEA=; b=OFpckkWtz/D0shaEVgW/WBvvpKS/TgyCceMVoKwrz29KKr3zEgHwS9qcloiMyPIsw1 FvM7nLGnY4xqzaQbLNUcFziybaqcXV7sB36wBarJ8EeKLa8VnB5alsiAG2GBF+pY1HLJ 02hIf5QVKkM0drxfXPDmicpWa1+z146ZHiT7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KaIdwrCkpiQm7QmH7kGEIFHkiXaTx0GXyebKeCAhIEA=; b=blXM8WvwnGdAQWLACxAxk01qUo3FWbJmRd9hsgXmhtkZZtLWHkIzM7Dq/8SzJ8Mv1d MaS2s5R3YRapF9brMydQNe86c04zgtgaRyhUe2GRcJuV9+SFuu9B/35rvvRXDWixJRGp t+HN1MlFGoWJs3vOBZ4t9Oop+JJyjHaqKhKM14y44dgU94nO1P7MzBN+lMjjmgLXl7jK 09YJJD+pCVXNQRDthQo0OGVHMnL2oNF+iDmqIKeqhtfOWIsfml/8cELTm2DG0hcxULjD cU6gsTAbooTsCWk9zdQ0mmmEpVemYIfYn6I/+nd8G2jzBFG53o3t96Zo25PU268VLOc/ 8TzQ== X-Gm-Message-State: APt69E3dKqCCC9spAQK/VEaS5s43D8JNwQce5zN1fHzNWXsbVLl77kmb Yql6lctW9Zpq4Rjv8oluPTOzZA== X-Google-Smtp-Source: ADUXVKIhfcgRDVsDXr0Pb2shf0ZQgT6EU4NABEC6Mefc221b5rmqx6iza1uMjqKb9SClJZ0rsRl0Tg== X-Received: by 2002:a81:3050:: with SMTP id w77-v6mr10500273yww.88.1529527733466; Wed, 20 Jun 2018 13:48:53 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id p3-v6sm1173865ywh.36.2018.06.20.13.48.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 13:48:52 -0700 (PDT) From: Sean Paul To: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: robdclark@gmail.com, hoegsberg@chromium.org, jsanka@codeaurora.org, abhinavk@codeaurora.org, Sean Paul Subject: [DPU PATCH 12/19] drm/msm: dpu_mdss: Replace DPU_EVT with DRM_ERROR Date: Wed, 20 Jun 2018 16:48:34 -0400 Message-Id: <20180620204841.56354-13-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.rc1.244.gcf134e6275-goog In-Reply-To: <20180620204841.56354-1-seanpaul@chromium.org> References: <20180620204841.56354-1-seanpaul@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The events are only issued in error cases, so use DRM_ERROR instead. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c index 04accdf483c0..5c69c2cc5d10 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c @@ -33,13 +33,14 @@ static irqreturn_t dpu_mdss_irq(int irq, void *arg) mapping = irq_find_mapping(dpu_mdss->irq_controller.domain, hwirq); if (mapping == 0) { - DPU_EVT32(hwirq, DPU_EVTLOG_ERROR); + DRM_ERROR("couldn't find irq mapping for %lu\n", hwirq); return IRQ_NONE; } rc = generic_handle_irq(mapping); if (rc < 0) { - DPU_EVT32(hwirq, mapping, rc, DPU_EVTLOG_ERROR); + DRM_ERROR("handle irq fail: irq=%lu mapping=%u rc=%d\n", + hwirq, mapping, rc); return IRQ_NONE; }