From patchwork Thu Jun 21 19:02:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10480429 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5738E60230 for ; Thu, 21 Jun 2018 19:02:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39A1A2919E for ; Thu, 21 Jun 2018 19:02:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E54D291A0; Thu, 21 Jun 2018 19:02:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9214291A3 for ; Thu, 21 Jun 2018 19:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbeFUTCl (ORCPT ); Thu, 21 Jun 2018 15:02:41 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:42829 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbeFUTCl (ORCPT ); Thu, 21 Jun 2018 15:02:41 -0400 Received: by mail-yb0-f195.google.com with SMTP id m199-v6so1622793ybm.9 for ; Thu, 21 Jun 2018 12:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=ZmjTdA6/m06Gcs9dmc2VS85nFuv0GUJyxehhnbR6nsg=; b=WuRGwMr2YtBcUbYqQpTPgrBsUeoibEPLlOcUMrLIaqOga+eUb9MLYugGlNq6mA/Iz/ 456GdyWHtmqIJ3/IU8ok07yjroR1oeAWMVyhQRnankcz/tP7u2S/cLu2kcf90XGAmKyt 4fJ8ZBZLBcX39bbUxxGVTTX0/oRBTnPqJaX60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZmjTdA6/m06Gcs9dmc2VS85nFuv0GUJyxehhnbR6nsg=; b=t1T58dDwmvqlM5LFx4YOwpaMEcUFO2tCm6O8nmrU/DuEd7W0B/WACxVadwgPvHqHqe JSNf9wbCSm2nIWeWt0ygSimlwndJ49nhmzgyxtdTgzWVjaG+v2HZlqsN3/SP9YCEAY8E ZC8WzPfH9g4EHcEKR9tIBpIimVyQ+abir9R9Pyg6NZ2bkVksr0+RgyyGZpayl2OQoYoK D2FkWhUfkJmCaxMpO/H6stJlVouGgiPcsqH4i+tVcG3do0bJAl9ZyLL2pjXUpBa06LQu PW5IC03TWs/7EZnptYfaubI30U0ZL3Gm0V/M9WTMc+ifhzP3/qCGLDP988dcNH6x2xIf 5Udw== X-Gm-Message-State: APt69E3RRcPGRZJxC99fQSCLwQSNpZwA1fLQE2I9BPjLjxCq+FnkNAX0 h3E6tWd8J/bZcWzrPFZDpyyfOg== X-Google-Smtp-Source: ADUXVKIwumaJXaL/5xFn6/8GHW4zXAm+8VBL5tqKyZJoG6s78sgCoz4bGZvqagO8rzAMQmyBXWhPEA== X-Received: by 2002:a25:af52:: with SMTP id c18-v6mr2209598ybj.127.1529607760585; Thu, 21 Jun 2018 12:02:40 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id f131-v6sm2021021ywh.18.2018.06.21.12.02.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 12:02:39 -0700 (PDT) From: Sean Paul To: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: robdclark@gmail.com, hoegsberg@chromium.org, jsanka@codeaurora.org, abhinavk@codeaurora.org, Sean Paul Subject: [DPU PATCH 1/2] drm/msm: dpu: Remove dpu_format_populate_layout_with_roi() Date: Thu, 21 Jun 2018 15:02:38 -0400 Message-Id: <20180621190239.196436-1-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.rc2.346.g013aa6912e-goog Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's unused, so let's get rid of it. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 31 --------------------- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 ----------- 2 files changed, 47 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index deaf4a33b776..12dc6a9d3b25 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -1124,37 +1124,6 @@ static void _dpu_format_calc_offset_linear(struct dpu_hw_fmt_layout *source, } } -int dpu_format_populate_layout_with_roi( - struct msm_gem_address_space *aspace, - struct drm_framebuffer *fb, - struct dpu_rect *roi, - struct dpu_hw_fmt_layout *layout) -{ - int ret; - - ret = dpu_format_populate_layout(aspace, fb, layout); - if (ret || !roi) - return ret; - - if (!roi->w || !roi->h || (roi->x + roi->w > fb->width) || - (roi->y + roi->h > fb->height)) { - DRM_ERROR("invalid roi=[%d,%d,%d,%d], fb=[%u,%u]\n", - roi->x, roi->y, roi->w, roi->h, - fb->width, fb->height); - ret = -EINVAL; - } else if (DPU_FORMAT_IS_LINEAR(layout->format)) { - _dpu_format_calc_offset_linear(layout, roi->x, roi->y); - layout->width = roi->w; - layout->height = roi->h; - } else if (roi->x || roi->y || (roi->w != fb->width) || - (roi->h != fb->height)) { - DRM_ERROR("non-linear layout with roi not supported\n"); - ret = -EINVAL; - } - - return ret; -} - int dpu_format_check_modified_format( const struct msm_kms *kms, const struct msm_format *msm_fmt, diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h index 6aa91de93cac..b55bfd13e296 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h @@ -115,22 +115,6 @@ int dpu_format_populate_layout( struct drm_framebuffer *fb, struct dpu_hw_fmt_layout *fmtl); -/** - * dpu_format_populate_layout_with_roi - populate the given format layout - * based on mmu, fb, roi, and format found in the fb - * @aspace: address space pointer - * @fb: framebuffer pointer - * @roi: region of interest (optional) - * @fmtl: format layout structure to populate - * - * Return: error code on failure, 0 on success - */ -int dpu_format_populate_layout_with_roi( - struct msm_gem_address_space *aspace, - struct drm_framebuffer *fb, - struct dpu_rect *roi, - struct dpu_hw_fmt_layout *fmtl); - /** * dpu_format_get_framebuffer_size - get framebuffer memory size * @format: DRM pixel format