From patchwork Tue Jun 26 09:20:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10488377 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98AA7602D8 for ; Tue, 26 Jun 2018 09:23:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 879A026E97 for ; Tue, 26 Jun 2018 09:23:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C32627FA9; Tue, 26 Jun 2018 09:23:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F50F26E97 for ; Tue, 26 Jun 2018 09:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934011AbeFZJXG (ORCPT ); Tue, 26 Jun 2018 05:23:06 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33292 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933868AbeFZJWg (ORCPT ); Tue, 26 Jun 2018 05:22:36 -0400 Received: by mail-wm0-f51.google.com with SMTP id z6-v6so14761498wma.0 for ; Tue, 26 Jun 2018 02:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E2b1SF4lGljXSzLfPBJn6UYbkgznGupv6vAh0HdCRDw=; b=WiSBo2VIvv0zIiPAaiAstN0mLB+Ie6xfF4IWD1J9gArWonO8jGdVczMzamSNW52mAt valQvT10y+MlBNSzOZkn4OHO7mHzkmlsewH6gcIkXbO/1mxSfRnSr0yzlcTN7tT/bTAX ES2G8QELF74VCqJlGy/gBbkNxz95kpLW2Qs44= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E2b1SF4lGljXSzLfPBJn6UYbkgznGupv6vAh0HdCRDw=; b=djenjGPXXr6359c7cdK+YuNInDZ0a1yZlfyXEZ1NlD7xM6+4kQNKbWxeNc7Y6bOQMu zavZVQGZoeJpgk/l8mYzmbN3Q0uGiR+9N/6Wa3QBd12gWwBKMgdFvXPaIp9cf6ow5r8Y x7VQmPmbBLfOz+h3hFcCmYObWRAQKPGHAY2J0Yb8PODmqSlTHcBhBhrWnJV9ON33388A RR1Iszj+oSfWY0zqKAz9X167+VzKsjbcIvdYHaSZ8c+tqAu5jE53Fq6bENWbLoal248Z hM1hojJYNJe164xeHxnGNg3oPSqbpJBoOzLYo9xWhu8EFIoeZX/qh4/YJavW1iBy6iB9 RBvw== X-Gm-Message-State: APt69E3MKoeuC3KY61bNbRt73pnXRfTD+1qyzypeFjgTNOsZbW17w4+H v5YCpBg+NegCrLHR8ugUzFJPsg== X-Google-Smtp-Source: AAOMgpfTR1J6W5SXAmymsM/QkUqQ2iA7pd84rmBofWlWZS+mXIeCiX8Npd2xIc3zJmEToJIZyH6pfQ== X-Received: by 2002:a1c:b3c3:: with SMTP id c186-v6mr984726wmf.41.1530004955576; Tue, 26 Jun 2018 02:22:35 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id x5-v6sm1438456wrr.3.2018.06.26.02.22.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 02:22:35 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org, tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, Srinivas Kandagatla Subject: [PATCH v2 11/12] ASoC: qdsp6: q6routing: add proper error check Date: Tue, 26 Jun 2018 10:20:15 +0100 Message-Id: <20180626092016.9296-12-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> References: <20180626092016.9296-1-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP q6adm_open can return error pointer or a null in error cases. Fix the return handling. Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel --- sound/soc/qcom/qdsp6/q6routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index ab696bf8d1d3..c80fdbc2442e 100644 --- a/sound/soc/qcom/qdsp6/q6routing.c +++ b/sound/soc/qcom/qdsp6/q6routing.c @@ -310,7 +310,7 @@ int q6routing_stream_open(int fedai_id, int perf_mode, session->channels, topology, perf_mode, session->bits_per_sample, 0, 0); - if (!copp) { + if (IS_ERR_OR_NULL(copp)) { mutex_unlock(&routing_data->lock); return -EINVAL; }