From patchwork Mon Jul 9 17:31:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10515351 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10BE3600CA for ; Mon, 9 Jul 2018 17:33:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB53228DCC for ; Mon, 9 Jul 2018 17:33:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DEC0A28DD3; Mon, 9 Jul 2018 17:33:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82F3128DCC for ; Mon, 9 Jul 2018 17:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933705AbeGIRdp (ORCPT ); Mon, 9 Jul 2018 13:33:45 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:35365 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933558AbeGIRdp (ORCPT ); Mon, 9 Jul 2018 13:33:45 -0400 Received: by mail-yb0-f194.google.com with SMTP id x15-v6so7504631ybm.2 for ; Mon, 09 Jul 2018 10:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=NKhva+k9MOz3BPQrdva+VwI2nQ6lrNqX0ByEkWw8dp0=; b=HsAf0BYTecLl1/AoS10Y4NiEE46SBoN4N/mWc5TRGyVRrM82ETs0SioieBvz8vn66P CJH2M22usGOnjyQdtE37iSValCpsQmsp+iI5cjC/IjTb4WRWAJsFE4zvWYZ69vYgePgY qPKh7qaBt/lci5MYPhZJeeEXUqvSWvahtpMtk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=NKhva+k9MOz3BPQrdva+VwI2nQ6lrNqX0ByEkWw8dp0=; b=WA6xSqNdvV1Pb5pzxLdUYtvNOso0AzAQIe1yJRj/OUalawMeWJRA5nG9b1qE+jAJQQ O5YoKhXoaPSEnkzXnTfEwSKoCEt1r+mg6Syyghw8KKzfExziMpaxrxf44K78IgrgVvsw k7DTKW0+rlnb9BbrQ/S8egH6Ym5XI2XkHJekdDz9JVcs9sKthqAYkXayR6FrBWyFH9g7 Z3pAqeR/Udsg4QxI/mZ4KhrnqqnQRBh07SmpFbVJoIUcpY3gO8epaKZeBF9UoLbUNqH4 kZzhq5Sr72yUiyL3uGD1vWi2wZLLeaw83uNg/dArdymNH9CCBGj7Um1FxEcJWs/uHcMT CRoQ== X-Gm-Message-State: APt69E3V3pmSqWJP8lKOMvuTF6Lue3jvjiIsgcI2UoMwXcLKgdrLyLOu clesWoJcHbkpCv+r+qdibUIQmg== X-Google-Smtp-Source: AAOMgpfiMYi6mQaXYkfOTVE2dfF8RZso+RpFkC0U7xnYaUBTjc5uetrLtLDZMOHHUbBYBnBJdKaVcg== X-Received: by 2002:a25:94c:: with SMTP id u12-v6mr11612313ybm.435.1531157624748; Mon, 09 Jul 2018 10:33:44 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id s206-v6sm5885495ywc.55.2018.07.09.10.33.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 10:33:44 -0700 (PDT) From: Sean Paul To: abhinavk@codeaurora.org, architt@codeaurora.org, chandanu@codeaurora.org, jsanka@codeaurora.org, jcrouse@codeaurora.org, ryadav@codeaurora.org, seanpaul@chromium.org, skolluku@codeaurora.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, airlied@linux.ie, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, nganji@codeaurora.org, hoegsberg@chromium.org, dovizu@chromium.org, robh+dt@kernel.org Subject: [PATCH 07/21] drm/msm/dsi: initialize postdiv_lock before use for 10nm pll Date: Mon, 9 Jul 2018 13:31:43 -0400 Message-Id: <20180709173200.238457-8-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.203.gfac676dfb9-goog In-Reply-To: <20180709173200.238457-1-seanpaul@chromium.org> References: <20180709173200.238457-1-seanpaul@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rajesh Yadav postdiv_lock spinlock was used before initialization for 10nm pll. It causes following spin_bug: "BUG: spinlock bad magic on CPU#0". Initialize spinlock before its usage. Signed-off-by: Rajesh Yadav Signed-off-by: Sean Paul Reviewed-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index c4c37a7df637..4c03f0b7343e 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -798,6 +798,8 @@ struct msm_dsi_pll *msm_dsi_pll_10nm_init(struct platform_device *pdev, int id) return ERR_PTR(-ENOMEM); } + spin_lock_init(&pll_10nm->postdiv_lock); + pll = &pll_10nm->base; pll->min_rate = 1000000000UL; pll->max_rate = 3500000000UL;