From patchwork Mon Jul 30 15:26:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10549229 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA3131751 for ; Mon, 30 Jul 2018 15:28:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A8BF29B2F for ; Mon, 30 Jul 2018 15:28:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8ED6629B44; Mon, 30 Jul 2018 15:28:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 389B429B2F for ; Mon, 30 Jul 2018 15:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbeG3RDc (ORCPT ); Mon, 30 Jul 2018 13:03:32 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36679 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbeG3RDc (ORCPT ); Mon, 30 Jul 2018 13:03:32 -0400 Received: by mail-yw0-f195.google.com with SMTP id v197-v6so4500646ywg.3 for ; Mon, 30 Jul 2018 08:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j4POr+FyfvY6N0WItcaRoSqfe6/JQAhWZIMc05h/GWc=; b=nMfyZhIFAQ57W+eg94D2o5zCjS5mp2moln02bwpPSJFqLB2ZaPhDDqFkkEbzkg1wqS 2yR6Gr611Gc+gTM5I2iguphC3AXSF12lnjehyVuoyuB/d1HrBSe+FuyFttYnGjz8kjQA kU7ENKlFymtXjgN/oNdgW06kQmoxOLslqo8qI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j4POr+FyfvY6N0WItcaRoSqfe6/JQAhWZIMc05h/GWc=; b=CkpOJCGJ3HVoUwF639gelH+6QU9suaQ069o57WeHOmiLkY3hkR72bl4JM8SzaCKSCz pMDzdUAFuAH3Iv+sa2bySm/FXv477bow0B/yRtPFI/9KifKw+iF0ACzDA17dobzyZIq/ ggSO/0OU/fvAkThqPw6hfFaTzPXkW09W3TprO3yVGuLfPJF8sQlL/PzWkECRrAhMiC1O MwJ8i9cqeKQk7F8laTFFuUs+Ku/v45G+bYmayBbnCdSTzA0UXsvz34jKPvhB+Qbh/6Rk +avYorYkA7HKWZha1dtqKPl++8E2yqPdK+xsoim07mJTQI+XUfQJEBXid28LBay71oJ9 goDA== X-Gm-Message-State: AOUpUlEJPLh3S1TCUp8x/vhILl93kU2I9TKkKzOZaqHouZMYyQpEKoZp 5ihEXJOiXC2Pr7x5ANlWH/fA3Q== X-Google-Smtp-Source: AAOMgpfhh1vm/vr9EUkkBz2vKNYPg6N0WOXnqQ5eWym95VWoRNye0YkZzG7o75kAd+AaxfzlBSWp6A== X-Received: by 2002:a0d:e254:: with SMTP id l81-v6mr9220883ywe.220.1532964482806; Mon, 30 Jul 2018 08:28:02 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id s63-v6sm937383ywd.63.2018.07.30.08.28.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jul 2018 08:28:02 -0700 (PDT) From: Sean Paul To: robdclark@gmail.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: dianders@chromium.org, Sean Paul , Archit Taneja , Abhinav Kumar Subject: [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails Date: Mon, 30 Jul 2018 11:26:54 -0400 Message-Id: <20180730152658.157098-3-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.345.g5c9ce644c3-goog In-Reply-To: <20180730152658.157098-1-seanpaul@chromium.org> References: <20180730152658.157098-1-seanpaul@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If dt parsing fails, we should return an error instead of pretending everything completed successfully. Cc: Doug Anderson Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 96fb5f635314..9c6c523eacdc 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1750,6 +1750,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host) if (ret) { dev_err(dev, "%s: invalid lane configuration %d\n", __func__, ret); + ret = -EINVAL; goto err; } @@ -1757,6 +1758,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host) device_node = of_graph_get_remote_node(np, 1, 0); if (!device_node) { dev_dbg(dev, "%s: no valid device\n", __func__); + ret = -ENODEV; goto err; }