From patchwork Wed Oct 17 13:55:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sibi Sankar X-Patchwork-Id: 10645661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDB24109C for ; Wed, 17 Oct 2018 13:55:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9D082AE9A for ; Wed, 17 Oct 2018 13:55:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCE932AEAB; Wed, 17 Oct 2018 13:55:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 673272AE9A for ; Wed, 17 Oct 2018 13:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbeJQVvq (ORCPT ); Wed, 17 Oct 2018 17:51:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44094 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbeJQVvq (ORCPT ); Wed, 17 Oct 2018 17:51:46 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B2F1C61371; Wed, 17 Oct 2018 13:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539784555; bh=E732yZacHh5Js6UCJf8iPHfocQFXpXKKNzpzQXWw0EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oi+WE38fCCOjczbvV037oxHFUp2x4ym7NKymICFGOXe9hwcK4GhFddQ93uzQT7s6T yQREeDCSElB/3xOkFmjNmKnvnUKa6hUeI3dNyo3YZ0IAkzlu0k2HEmDrqBTqRQkt8X q5XuTy1XkQhhaSnv4aN6Cmkxx0IM1QVbWH5t5h6Y= Received: from blr-ubuntu-87.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sibis@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 20BF761364; Wed, 17 Oct 2018 13:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539784555; bh=E732yZacHh5Js6UCJf8iPHfocQFXpXKKNzpzQXWw0EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oi+WE38fCCOjczbvV037oxHFUp2x4ym7NKymICFGOXe9hwcK4GhFddQ93uzQT7s6T yQREeDCSElB/3xOkFmjNmKnvnUKa6hUeI3dNyo3YZ0IAkzlu0k2HEmDrqBTqRQkt8X q5XuTy1XkQhhaSnv4aN6Cmkxx0IM1QVbWH5t5h6Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 20BF761364 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sibis@codeaurora.org From: Sibi Sankar To: bjorn.andersson@linaro.org, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org, sricharan@codeaurora.org, akdwived@codeaurora.org, kyan@codeaurora.org, Sibi Sankar Subject: [PATCH v5 2/5] remoteproc: Add mechanism for custom dump function assignment Date: Wed, 17 Oct 2018 19:25:24 +0530 Message-Id: <20181017135527.30592-3-sibis@codeaurora.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181017135527.30592-1-sibis@codeaurora.org> References: <20181017135527.30592-1-sibis@codeaurora.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a mechanism for assigning each rproc dump segment with a custom dump function and private data. The dump function is to be called for each rproc segment during coredump if assigned. Signed-off-by: Sibi Sankar --- drivers/remoteproc/remoteproc_core.c | 39 ++++++++++++++++++++++++++++ include/linux/remoteproc.h | 5 ++++ 2 files changed, 44 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index afa4274b6ccd..076579f44c3a 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1121,6 +1121,45 @@ int rproc_coredump_add_segment(struct rproc *rproc, dma_addr_t da, size_t size) } EXPORT_SYMBOL(rproc_coredump_add_segment); +/** + * rproc_coredump_add_custom_segment() - add segment of device memory to + * coredump and extend it with custom + * dump function + * @rproc: handle of a remote processor + * @da: device address + * @size: size of segment + * @priv: private data + * @dumpfn: custom dump function called for each segment during coredump + * + * Add device memory to the list of segments to be included in the coredump + * and associate the segment with the given custom dump function and private + * data. + * + * Return: 0 on success, negative errno on error. + */ +int rproc_coredump_add_custom_segment(struct rproc *rproc, + dma_addr_t da, size_t size, void *priv, + void (*dumpfn)(struct rproc *rproc, + struct rproc_dump_segment *segment, + void *dest)) +{ + struct rproc_dump_segment *segment; + + segment = kzalloc(sizeof(*segment), GFP_KERNEL); + if (!segment) + return -ENOMEM; + + segment->da = da; + segment->size = size; + segment->priv = priv; + segment->dump = dumpfn; + + list_add_tail(&segment->node, &rproc->dump_segments); + + return 0; +} +EXPORT_SYMBOL(rproc_coredump_add_custom_segment); + /** * rproc_coredump() - perform coredump * @rproc: rproc handle diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index 2a93e102d2ad..0003b23ab117 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -563,6 +563,11 @@ int rproc_boot(struct rproc *rproc); void rproc_shutdown(struct rproc *rproc); void rproc_report_crash(struct rproc *rproc, enum rproc_crash_type type); int rproc_coredump_add_segment(struct rproc *rproc, dma_addr_t da, size_t size); +int rproc_coredump_add_custom_segment(struct rproc *rproc, + dma_addr_t da, size_t size, void *priv, + void (*dumpfn)(struct rproc *rproc, + struct rproc_dump_segment *segment, + void *dest)); static inline struct rproc_vdev *vdev_to_rvdev(struct virtio_device *vdev) {