From patchwork Tue Oct 23 01:07:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Case X-Patchwork-Id: 10652643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55E1917D4 for ; Tue, 23 Oct 2018 01:07:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9F2929045 for ; Tue, 23 Oct 2018 01:07:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E476290D1; Tue, 23 Oct 2018 01:07:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F26129045 for ; Tue, 23 Oct 2018 01:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726872AbeJWJ2r (ORCPT ); Tue, 23 Oct 2018 05:28:47 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34263 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbeJWJ2r (ORCPT ); Tue, 23 Oct 2018 05:28:47 -0400 Received: by mail-pg1-f195.google.com with SMTP id g12-v6so19838423pgs.1 for ; Mon, 22 Oct 2018 18:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Dw8Qjeswo1fiQxpz5TeSz6FDLID6QIN1kVfa3XtAzzU=; b=ntqVK65QU4fAuMQ4FX4SADMUkJ+bp8bILQEVaW7MtACQCD19Fy0t2x1cToxowaFqLw Yzc0R8+GIGsTqSZl1xb6cbM6vvm9n67vR9K9BB0ntgByDA/vs7dwLCdzLo08Cq1iUioM nS0kZ70w1br5uyxJQOxuqRjvCFtu9YuJ74zPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Dw8Qjeswo1fiQxpz5TeSz6FDLID6QIN1kVfa3XtAzzU=; b=MKznxHfUpp+qY9fFdSkCk4rwDPHTV02UCN61NkSia1G4QRbTNlmRsRwpFJzUOaS1aE +WhdoXP3ocqU4D6E/OXTEz4e9wtGJ/TZD8H9tWZV8DCtQZapT4ZYW2x1viVOlnx+pt42 hP1FsD4+MGEmwx24CWxnta8/C8eKdUnBMEndkk6K7EP4UfyCZouueq1BiFC7ZmBUBEUh DnmiAlNGTCAuCWQm1sUa+XVT0pcUMB6cGXRF9l7ooeXIEKwpSvAcoDe3OrAU8bo9DPpJ M70vKbM5VMRi9MjK3hwVpDglSpHH4avbOLVOJLQZdLKiN+xkN5dZYt9fnMqoKSDW9C2l Cm4Q== X-Gm-Message-State: ABuFfoifM2d2MmKoMmG2onUvTHpidZjMTFJIkpkCkyPXz01UwhI1n1wd 4/07xKEoggpaq8n+MiCmRCzBOA== X-Google-Smtp-Source: ACcGV61w8fPC2BD8dTB3NUJZ6CkLrtqlT2jNwgfTFWLFV2g+NeXsJbAJD+jMZX0k4Eyh3vNW8A/PBA== X-Received: by 2002:a63:2218:: with SMTP id i24-v6mr44657107pgi.238.1540256868779; Mon, 22 Oct 2018 18:07:48 -0700 (PDT) Received: from ryandcase.mtv.corp.google.com ([2620:15c:202:201:ed1c:3d1c:9d92:99cb]) by smtp.gmail.com with ESMTPSA id q24-v6sm38104982pff.83.2018.10.22.18.07.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 18:07:48 -0700 (PDT) From: Ryan Case To: Mark Brown Cc: linux-arm-msm@vger.kernel.org, Doug Anderson , Stephen Boyd , Ryan Case , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Date: Mon, 22 Oct 2018 18:07:07 -0700 Message-Id: <20181023010707.153647-1-ryandcase@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Address remaining comments from original driver patch series * Move RD_FIFO_CFG to be ordered corretly * Expand spinlock comment Signed-off-by: Ryan Case Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index b8163b40bb92..e0f061139c8f 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -90,6 +90,9 @@ #define PIO_DATAOUT_1B 0x0020 #define PIO_DATAOUT_4B 0x0024 +#define RD_FIFO_CFG 0x0028 +#define CONTINUOUS_MODE BIT(0) + #define RD_FIFO_STATUS 0x002c #define FIFO_EMPTY BIT(11) #define WR_CNTS_MSK 0x7f0 @@ -99,9 +102,6 @@ #define RDY_16BYTE BIT(1) #define FIFO_RDY BIT(0) -#define RD_FIFO_CFG 0x0028 -#define CONTINUOUS_MODE BIT(0) - #define RD_FIFO_RESET 0x0030 #define RESET_FIFO BIT(0) @@ -139,7 +139,7 @@ struct qcom_qspi { struct device *dev; struct clk_bulk_data clks[QSPI_NUM_CLKS]; struct qspi_xfer xfer; - /* Lock to protect data accessed by IRQs */ + /* Lock to protect xfer and IRQ accessed registers */ spinlock_t lock; };