From patchwork Tue Nov 20 00:26:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10689653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF2AF13BB for ; Tue, 20 Nov 2018 00:27:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A90282A3D2 for ; Tue, 20 Nov 2018 00:27:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B96E2A3F3; Tue, 20 Nov 2018 00:27:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41EA62A3D2 for ; Tue, 20 Nov 2018 00:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731351AbeKTKxY (ORCPT ); Tue, 20 Nov 2018 05:53:24 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:43293 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbeKTKxY (ORCPT ); Tue, 20 Nov 2018 05:53:24 -0500 Received: by mail-pl1-f193.google.com with SMTP id gn14so68204plb.10 for ; Mon, 19 Nov 2018 16:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AZnBqhOMiV0x8Nts3mmKhJTa0g/gCMAi6Irs/PqEMVY=; b=JwcHictgaQkYNO5P54osc7Htns94V1a2fCcS3nVYhHh39UlFaXOyv9ocOdpZm7wRR2 wNe5/2lv+d5d6Mttw+U0apMUuL1+YrCvm5hj38UpSDjfSo/rA6ppVgXlIxnjz1NIgDL2 tiXkA9V6txndjxlGKMTbIszBPmvsSltELHCw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AZnBqhOMiV0x8Nts3mmKhJTa0g/gCMAi6Irs/PqEMVY=; b=uEqGPeEiow+qWVnbVRHE3eJdPugdx98QiKcjYEynaj/I6/lZ/JPJvDLT3Z5X/O6R6/ 1WPkz/ggbPm+ad+tlI32HKSRZh1HtrA0sWO99yMpdABt4VHv0KmMdHLCrVFVLArWPUY8 dnrTdJ7ZT55rCt6ct2T/npDhzQjYv5We1R0luF5bkfeZbfOBj9eaYW9RWX4zmuA4bb4y eb09SH6CFPRzpZNpBWnbXUnn7gc2qsvmmnwhsa65RlOFaqgR15mKE1ESkxi7EkOZ5Yv1 oBDeDwoI5+jRpi+IvYJh3M+iaW3uAQv+H+mY7xwZr+Jt6BwSYONJ3Cm0TO1wg5t7Sp6Q gK4A== X-Gm-Message-State: AA+aEWZl3JKdxONFAd1YME5CaZRythcI3OBJX/2NsTZM79em7yMAtJzs kPchyfzS8H/rHHOjWtne5zJjNA== X-Google-Smtp-Source: AFSGD/U3rgSlM3Pcb0dVyysF2XF6NSyf7C0QgZ/k5D+l8/OP9yrKCBCZ+MTT1x83HpaLo+dMJruIHQ== X-Received: by 2002:a17:902:be0e:: with SMTP id r14-v6mr14343114pls.23.1542673626775; Mon, 19 Nov 2018 16:27:06 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id z83-v6sm55240218pfi.4.2018.11.19.16.27.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 16:27:05 -0800 (PST) From: Douglas Anderson To: Mark Brown Cc: Bjorn Andersson , evgreen@chromium.org, swboyd@chromium.org, Dmitry Osipenko , ryandcase@chromium.org, David Collins , linux-arm-msm@vger.kernel.org, Douglas Anderson , Liam Girdwood , linux-kernel@vger.kernel.org Subject: [PATCH 1/7] regulator: core: Properly expose requested_microamps in sysfs Date: Mon, 19 Nov 2018 16:26:48 -0800 Message-Id: <20181120002654.1891-1-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.1215.g8438c0b245-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The "requested_microamps" sysfs attribute was only being exposed for "current" regulators. This didn't make sense. Allow it to be exposed always. Signed-off-by: Douglas Anderson --- drivers/regulator/core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index d7ffd7b12472..ff5ca185bb8f 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4565,10 +4565,6 @@ static umode_t regulator_attr_is_visible(struct kobject *kobj, if (attr == &dev_attr_bypass.attr) return ops->get_bypass ? mode : 0; - /* some attributes are type-specific */ - if (attr == &dev_attr_requested_microamps.attr) - return rdev->desc->type == REGULATOR_CURRENT ? mode : 0; - /* constraints need specific supporting methods */ if (attr == &dev_attr_min_microvolts.attr || attr == &dev_attr_max_microvolts.attr)