From patchwork Fri Dec 21 20:10:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 10741019 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 785B213B5 for ; Fri, 21 Dec 2018 20:10:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6842E2848B for ; Fri, 21 Dec 2018 20:10:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B54728538; Fri, 21 Dec 2018 20:10:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02FE22848B for ; Fri, 21 Dec 2018 20:10:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391859AbeLUUKZ (ORCPT ); Fri, 21 Dec 2018 15:10:25 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34042 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391855AbeLUUKZ (ORCPT ); Fri, 21 Dec 2018 15:10:25 -0500 Received: by mail-pf1-f194.google.com with SMTP id h3so3079945pfg.1 for ; Fri, 21 Dec 2018 12:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TkQMS53u/0Pk1o6GD7eFKUQxD9ITUcTLmDsH4Ut9q0s=; b=CWEbq7GPWlwQ6iMgiHrhv3oxoSL4rtrKFfFP20c1/fSCEWVOZyoL6ew/vRpDLfZ6Vo Y/8G6dBql63+Xkf10aan42bRfUkR9RA8BabXmeHM3J/e/ftiOXIMJTl2f0zB952ofVbE S2BF1PNSVhcso+VlmW0ePiusNbMNAOmOnHFAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TkQMS53u/0Pk1o6GD7eFKUQxD9ITUcTLmDsH4Ut9q0s=; b=XIBl34bHoW3hG1Z/9LhUhFB6DMqVaL0d3pgqAxQIA2cfyZoV2KHydb/90utq8MfjdQ k7T4EPAZsvQZ0ZjaklCozJ6r3/gN/cjoqeAQmheFjxztZoTE4bg7RadhENVPJxkMAzNH +4pC9NrI9vdi/4Ku6DWfMRDLPrybhBs184VsvLckpVgis+B9/WzEgIaDuMEihYX3CQC7 kvKaVOz11AyLNsxohtXdRdFOLlw29ej8OBLKRFsWVRzCnblPBmtPzO+46c1t23DUJK9Y E5yHeHTsKiB0HeuRHplSEC7FG4+IB6v8sxsz+BDSC52T/PWTqRroDqPa0h3d57nw0gsQ xLcQ== X-Gm-Message-State: AJcUukdBHoxGKRruhSom/W7oMRJWTBDnTzCMns3gNd6Xj48fnmM1xuh5 3T+7UVCBTBqto3EOakGNNMlEzg== X-Google-Smtp-Source: ALg8bN47i/VJhy6I/FBlTwf8bZAeg76QMXPRhxZHtwOZxCK0X+gbf9d0bVWsaSQ4ZWqAkwwFv/f+eg== X-Received: by 2002:a63:9809:: with SMTP id q9mr3723532pgd.109.1545423024160; Fri, 21 Dec 2018 12:10:24 -0800 (PST) Received: from evgreen2.mtv.corp.google.com ([2620:15c:202:201:ffda:7716:9afc:1301]) by smtp.gmail.com with ESMTPSA id o1sm35300406pgn.63.2018.12.21.12.10.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Dec 2018 12:10:23 -0800 (PST) From: Evan Green To: Andy Gross , Bjorn Andersson Cc: Brian Norris , Ben Chan , Evan Green , linux-arm-msm@vger.kernel.org, David Brown , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] soc: qcom: rmtfs-mem: Make sysfs attributes world-readable Date: Fri, 21 Dec 2018 12:10:01 -0800 Message-Id: <20181221201001.160613-3-evgreen@chromium.org> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20181221201001.160613-1-evgreen@chromium.org> References: <20181221201001.160613-1-evgreen@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In order to run an rmtfs daemon as an unprivileged user, that user would need access to the phys_addr and size sysfs attributes. Sharing these attributes with unprivileged users doesn't really leak anything sensitive, since if you have access to physical memory, the jig is up anyway. Make those attributes readable by all. Signed-off-by: Evan Green Reviewed-by: Brian Norris Reviewed-by: Bjorn Andersson --- Changes in v2: None drivers/soc/qcom/rmtfs_mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c index 99a1363ece254..815c11aeceb93 100644 --- a/drivers/soc/qcom/rmtfs_mem.c +++ b/drivers/soc/qcom/rmtfs_mem.c @@ -45,9 +45,9 @@ static ssize_t qcom_rmtfs_mem_show(struct device *dev, struct device_attribute *attr, char *buf); -static DEVICE_ATTR(phys_addr, 0400, qcom_rmtfs_mem_show, NULL); -static DEVICE_ATTR(size, 0400, qcom_rmtfs_mem_show, NULL); -static DEVICE_ATTR(client_id, 0400, qcom_rmtfs_mem_show, NULL); +static DEVICE_ATTR(phys_addr, 0444, qcom_rmtfs_mem_show, NULL); +static DEVICE_ATTR(size, 0444, qcom_rmtfs_mem_show, NULL); +static DEVICE_ATTR(client_id, 0444, qcom_rmtfs_mem_show, NULL); static ssize_t qcom_rmtfs_mem_show(struct device *dev, struct device_attribute *attr,