diff mbox series

[1/2] spi: spi-geni-qcom: Don't initialize completion for normal message

Message ID 20190110210253.23219-1-swboyd@chromium.org (mailing list archive)
State New, archived
Headers show
Series [1/2] spi: spi-geni-qcom: Don't initialize completion for normal message | expand

Commit Message

Stephen Boyd Jan. 10, 2019, 9:02 p.m. UTC
We only use this completion when we're doing something that isn't a
message transfer. For example, changing CS or aborting/canceling a
command. All of those situations properly reinitialize the completion
before sending the GENI the special command to change CS or cancel, etc.
Given that, let's remove the initialization here.

Cc: Girish Mahadevan <girishm@codeaurora.org>
Cc: Dilip Kota <dkota@codeaurora.org>
Cc: Alok Chauhan <alokc@codeaurora.org>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
 drivers/spi/spi-geni-qcom.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series


diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
index fdb7cb88fb56..c3e9464027d4 100644
--- a/drivers/spi/spi-geni-qcom.c
+++ b/drivers/spi/spi-geni-qcom.c
@@ -233,7 +233,6 @@  static int spi_geni_prepare_message(struct spi_master *spi,
 	struct geni_se *se = &mas->se;
 	geni_se_select_mode(se, GENI_SE_FIFO);
-	reinit_completion(&mas->xfer_done);
 	ret = setup_fifo_params(spi_msg->spi, spi);
 	if (ret)
 		dev_err(mas->dev, "Couldn't select mode %d\n", ret);