From patchwork Tue Feb 19 19:12:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 10820619 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 301591390 for ; Tue, 19 Feb 2019 19:12:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B6F42D480 for ; Tue, 19 Feb 2019 19:12:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0FADD2D491; Tue, 19 Feb 2019 19:12:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A319E2D47F for ; Tue, 19 Feb 2019 19:12:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbfBSTMf (ORCPT ); Tue, 19 Feb 2019 14:12:35 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40162 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbfBSTMe (ORCPT ); Tue, 19 Feb 2019 14:12:34 -0500 Received: by mail-pl1-f193.google.com with SMTP id bj4so10880779plb.7 for ; Tue, 19 Feb 2019 11:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=VHWMlfMrTM94H6bRgK8jtWQ5WLwGNoqEAx6AZJOMxRg=; b=SrulZOWaIyBv5yIc5mXmO3mFbboC90sxAkEqy69UQ6rSsYIjntnb5L1FSFvvIOZPBy WH0b24VW/e78Gr/mdQLXp2Cz+gCjOAEN55VLNUmhzauyfAE851KM9N4Ls1PXQMxttUn6 kBMLFDEvxIKE8K5cYzfcgIpj0Qohm9BLuIX+Q0AqWnZusR9hjcn4ly8GULAY0h196Sdf kBbYxNetwDYiIRYjxw2T1Q6Dw5XJbXxkctWy6C1r7b2JhJwOcXxhjKFVbpGTCTmd4Eeg ga1Ih3NI252JzZTYxtRaUUcUWuoi0PUoJQkUMOOBYV+/uh1gfuEBcp1rr1MIQTbadx3X dfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VHWMlfMrTM94H6bRgK8jtWQ5WLwGNoqEAx6AZJOMxRg=; b=Lwq2hE2PQbMDjGBjrrXjRkaJGybJy8W/8nEg2L97v+VzG+rPK1+KSdkj5TNJV6AuGh v6e7adDnPX2EPdA6kiesOSxL5PoTevZ580byrGYmaHX4y9gYgmhfVPz5S445iEs74ARZ hrBUVmI5yydBLsHmRgiVlk70qtEeTZyCRj94UUA1VipHYZiGVGsdLC/GZJU3BV+Vj4Pe 06JbKeFzR4A2BG2Xz8kxCZWPcNLV+2cELWs4CX9q2c3VLZJKaWa2xZi8CFGDVa325UDZ NGneAiB+dn160T4TiPWDZNKejLKEgaUGryMGGmXC1LpBmfLBpV/tQj3Wy1/U6eRwR6wf +xyg== X-Gm-Message-State: AHQUAub3u7jabvZbFpOC4zWPqAcxljpODS6uDy4Yva7Jn4NZp/RNSRXt /i/Xhs8Dbw7BRPsu+NHBaTi0vg== X-Google-Smtp-Source: AHgI3Ia3b6ZJlhKBY1BcA9LcZZe9n2aMztSYcGq1/yrdTjXG5zxg37y4BCsv61wBENeYZjCzBG1pyA== X-Received: by 2002:a17:902:bc88:: with SMTP id bb8mr32864928plb.12.1550603553928; Tue, 19 Feb 2019 11:12:33 -0800 (PST) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h64sm24910009pfc.142.2019.02.19.11.12.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 11:12:33 -0800 (PST) From: Bjorn Andersson To: Bjorn Andersson , Linus Walleij Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: qcom: spmi-gpio: Reorder debug print Date: Tue, 19 Feb 2019 11:12:53 -0800 Message-Id: <20190219191253.21712-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's reasonable to expect that people turn to the "gpio" debugfs file to first and foremost learn about the direction and value of a gpio, and second to that about it's pinconf. So reorder the value so each line reads: gpioN: direction value ... This also makes it consistent with the TLMM pinctrl driver's output in the same dump. Signed-off-by: Bjorn Andersson --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index cb512c7a5251..76e57ae2f6e8 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -675,11 +675,11 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev, else seq_printf(s, " %-4s", pad->output_enabled ? "out" : "in"); + seq_printf(s, " %-4s", pad->out_value ? "high" : "low"); seq_printf(s, " %-7s", pmic_gpio_functions[function]); seq_printf(s, " vin-%d", pad->power_source); seq_printf(s, " %-27s", biases[pad->pullup]); seq_printf(s, " %-10s", buffer_types[pad->buffer_type]); - seq_printf(s, " %-4s", pad->out_value ? "high" : "low"); seq_printf(s, " %-7s", strengths[pad->strength]); seq_printf(s, " atest-%d", pad->atest); seq_printf(s, " dtest-%d", pad->dtest_buffer);