| Message ID | 20190308083053.30631-3-rnayak@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | scsi: ufs: runtime pm fixes | expand |
Hi, > > Add an error check for pm_runtime_get_sync(), ignoring this can > hide issues with the runtime pm handling in the driver. Can you elaborate on those issues? I guess you've encountered some during your bring-up. > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > --- > drivers/scsi/ufs/ufshcd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 2ddf24466a62..060dc38cc582 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -8357,7 +8357,10 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > *mmio_base, unsigned int irq) > } > > /* Hold auto suspend until async scan completes */ > - pm_runtime_get_sync(dev); > + err = pm_runtime_get_sync(dev); > + if (err < 0) > + goto out_remove_scsi_host; > + > atomic_set(&hba->scsi_block_reqs_cnt, 0); > /* > * We are assuming that device wasn't put in sleep/power-down On your first patch you are incrementing the device's usage counter, To avoid any suspend during probe, but this comment above state some assumption of this very same issue. Is it still valid? Thanks, Avri
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 2ddf24466a62..060dc38cc582 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -8357,7 +8357,10 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) } /* Hold auto suspend until async scan completes */ - pm_runtime_get_sync(dev); + err = pm_runtime_get_sync(dev); + if (err < 0) + goto out_remove_scsi_host; + atomic_set(&hba->scsi_block_reqs_cnt, 0); /* * We are assuming that device wasn't put in sleep/power-down
Add an error check for pm_runtime_get_sync(), ignoring this can hide issues with the runtime pm handling in the driver. Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)