From patchwork Fri Mar 8 08:30:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajendra Nayak X-Patchwork-Id: 10844313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDEFF1669 for ; Fri, 8 Mar 2019 08:31:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCA692E28B for ; Fri, 8 Mar 2019 08:31:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C060B2E2A5; Fri, 8 Mar 2019 08:31:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A2FF2E28B for ; Fri, 8 Mar 2019 08:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbfCHIbl (ORCPT ); Fri, 8 Mar 2019 03:31:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35868 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfCHIbi (ORCPT ); Fri, 8 Mar 2019 03:31:38 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4465C602BA; Fri, 8 Mar 2019 08:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1552033898; bh=a24jmQoPWqyDJptJlj3oRA4mUTzWhIfrj+Q4I+O9kSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lFGu56ucBAn7Ajv2VDEFhDpIfhMLSmRholwws22G99noC2oFZTH/1Osqfe+oq99IY cUUwutmxkohNwBOE4W7EaB8Il+ft5N7DLvtH+02uPxajncdBhfd/V/tGGMmM4xcDDr tswzTbr/aONPjjq8PsfCrjSYh1/BZ8ZmKQNQNeUg= Received: from blr-ubuntu-173.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rnayak@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 492D461195; Fri, 8 Mar 2019 08:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1552033897; bh=a24jmQoPWqyDJptJlj3oRA4mUTzWhIfrj+Q4I+O9kSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kI2sLTGYmJ1dKyqppG9aVCwEQoh83TleGta3FS/McKAtyHP5cRcW36TPGcikMelsU xjFQFNVNzHqECUzQaKegIvoVOZRQcFauefNe5E1PBMp6TaFGxCrFgLPrw6IX432dX6 dn+ENlP719b7m3KZDfRM/V2CTozuPa4EenLTOKfQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 492D461195 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rnayak@codeaurora.org From: Rajendra Nayak To: vinholikatti@gmail.com, alim.akhtar@samsung.com, pedrom.Sousa@synopsys.com Cc: subhashj@codeaurora.org, asutoshd@codeaurora.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak Subject: [PATCH 3/3] scsi: ufs: qcom: Remove unnecessary runtime pm calls Date: Fri, 8 Mar 2019 14:00:53 +0530 Message-Id: <20190308083053.30631-4-rnayak@codeaurora.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190308083053.30631-1-rnayak@codeaurora.org> References: <20190308083053.30631-1-rnayak@codeaurora.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Doing a runtime pm get/put as part of ufs_qcom_testbus_config() seems completely unnecessary, since this is called only early during ufs_qcom_init() when the runtime operations are not completely setup for ufs runtime suspend/resume to even work. Signed-off-by: Rajendra Nayak --- drivers/scsi/ufs/ufs-qcom.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 3aeadb14aae1..3590741eea2f 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -1558,7 +1558,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host) } mask <<= offset; - pm_runtime_get_sync(host->hba->dev); ufshcd_hold(host->hba, false); ufshcd_rmwl(host->hba, TEST_BUS_SEL, (u32)host->testbus.select_major << 19, @@ -1573,7 +1572,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host) */ mb(); ufshcd_release(host->hba); - pm_runtime_put_sync(host->hba->dev); return 0; }