| Message ID | 20190324163209.17312-5-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | arm64: dts: qcom: qcs404: ethernet and other updates | expand |
On Sun 24 Mar 09:32 PDT 2019, Vinod Koul wrote: > From: Shawn Guo <shawn.guo@linaro.org> > > It defines pinctrl settings for blsp1_uart3 in board level dts and > enable the device by toggling 'status'. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > Signed-off-by: Abhinav Asati <asatiabhi@codeaurora.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> How about a review of this patch instead? https://lore.kernel.org/lkml/20190305070823.11845-1-bjorn.andersson@linaro.org/ Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > index 323f9633084b..d4fadeaa0bbc 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > @@ -7,6 +7,7 @@ > / { > aliases { > serial0 = &blsp1_uart2; > + serial1 = &blsp1_uart3; > }; > > chosen { > @@ -137,6 +138,11 @@ > }; > > &tlmm { > + blsp1_uart3_default: blsp1-uart3-default { > + drive-strength = <2>; > + bias-disable; > + }; > + > sdc1_on: sdc1-on { > clk { > pins = "sdc1_clk"; > @@ -205,3 +211,7 @@ > bias-disable; > }; > }; > + > +&blsp1_uart3 { > + status = "okay"; > +}; > -- > 2.20.1 >
On 24-03-19, 09:55, Bjorn Andersson wrote: > On Sun 24 Mar 09:32 PDT 2019, Vinod Koul wrote: > > > From: Shawn Guo <shawn.guo@linaro.org> > > > > It defines pinctrl settings for blsp1_uart3 in board level dts and > > enable the device by toggling 'status'. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Signed-off-by: Abhinav Asati <asatiabhi@codeaurora.org> > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > How about a review of this patch instead? > > https://lore.kernel.org/lkml/20190305070823.11845-1-bjorn.andersson@linaro.org/ Done lgtm..
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi index 323f9633084b..d4fadeaa0bbc 100644 --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi @@ -7,6 +7,7 @@ / { aliases { serial0 = &blsp1_uart2; + serial1 = &blsp1_uart3; }; chosen { @@ -137,6 +138,11 @@ }; &tlmm { + blsp1_uart3_default: blsp1-uart3-default { + drive-strength = <2>; + bias-disable; + }; + sdc1_on: sdc1-on { clk { pins = "sdc1_clk"; @@ -205,3 +211,7 @@ bias-disable; }; }; + +&blsp1_uart3 { + status = "okay"; +};