diff mbox series

[RESEND,v4,4/4] usb: dwc3: qcom: Improve error handling

Message ID 20190617125105.6186-5-lee.jones@linaro.org (mailing list archive)
State Accepted
Commit 7f5d6a4696170ca7394d9dcecd5a54ebe2b9a067
Headers show
Series I2C: DWC3 USB: Add support for ACPI based AArch64 Laptops | expand

Commit Message

Lee Jones June 17, 2019, 12:51 p.m. UTC
dwc3_qcom_clk_init() is called with of_count_phandle_with_args() as an
argument.  If of_count_phandle_with_args() returns an error, the number
of clocks will be a negative value and will lead to undefined behaviour.

Ensure we check for an error before attempting to blindly use the value.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
 drivers/usb/dwc3/dwc3-qcom.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index 2d050303d564..c59e9d8e8609 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -409,6 +409,9 @@  static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count)
 	if (!np || !count)
 		return 0;
+	if (count < 0)
+		return count;
 	qcom->num_clocks = count;
 	qcom->clks = devm_kcalloc(dev, qcom->num_clocks,