diff mbox series

[v2] soc: qcom: socinfo: Annotate switch cases with fall through

Message ID 20190807022356.8502-1-bjorn.andersson@linaro.org (mailing list archive)
State Accepted
Commit 7bea41c4a25675a32bc3a63cfbd98099fdfb2695
Headers show
Series [v2] soc: qcom: socinfo: Annotate switch cases with fall through | expand

Commit Message

Bjorn Andersson Aug. 7, 2019, 2:23 a.m. UTC
Introduce fall through annotations in the switch statements of
socinfo_debugfs_init() to silence compiler warnings.

Fixes: 9c84c1e78634 ("soc: qcom: socinfo: Expose custom attributes")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/soc/qcom/socinfo.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Vaishali Thakkar Aug. 7, 2019, 4:25 a.m. UTC | #1
On Wed, 7 Aug 2019 at 07:54, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> Introduce fall through annotations in the switch statements of
> socinfo_debugfs_init() to silence compiler warnings.

Oops, I missed this. Thanks for fixing it!

> Fixes: 9c84c1e78634 ("soc: qcom: socinfo: Expose custom attributes")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Acked-by: Vaishali Thakkar <vaishali.thakkar@linaro.org>

> ---
>  drivers/soc/qcom/socinfo.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 855353bed19e..a39ea5061dc5 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -323,6 +323,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_x32("raw_device_number", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.raw_device_num);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 11):
>         case SOCINFO_VERSION(0, 10):
>         case SOCINFO_VERSION(0, 9):
> @@ -330,10 +331,12 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>
>                 debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.foundry_id);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 8):
>         case SOCINFO_VERSION(0, 7):
>                 DEBUGFS_ADD(info, pmic_model);
>                 DEBUGFS_ADD(info, pmic_die_rev);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 6):
>                 qcom_socinfo->info.hw_plat_subtype =
>                         __le32_to_cpu(info->hw_plat_subtype);
> @@ -341,6 +344,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_u32("hardware_platform_subtype", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.hw_plat_subtype);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 5):
>                 qcom_socinfo->info.accessory_chip =
>                         __le32_to_cpu(info->accessory_chip);
> @@ -348,23 +352,27 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_u32("accessory_chip", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.accessory_chip);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 4):
>                 qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
>
>                 debugfs_create_u32("platform_version", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.plat_ver);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 3):
>                 qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
>
>                 debugfs_create_u32("hardware_platform", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.hw_plat);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 2):
>                 qcom_socinfo->info.raw_ver  = __le32_to_cpu(info->raw_ver);
>
>                 debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.raw_ver);
> +               /* Fall through */
>         case SOCINFO_VERSION(0, 1):
>                 DEBUGFS_ADD(info, build_id);
>                 break;
> --
> 2.18.0
>
diff mbox series

Patch

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 855353bed19e..a39ea5061dc5 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -323,6 +323,7 @@  static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_x32("raw_device_number", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.raw_device_num);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 11):
 	case SOCINFO_VERSION(0, 10):
 	case SOCINFO_VERSION(0, 9):
@@ -330,10 +331,12 @@  static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 
 		debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.foundry_id);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 8):
 	case SOCINFO_VERSION(0, 7):
 		DEBUGFS_ADD(info, pmic_model);
 		DEBUGFS_ADD(info, pmic_die_rev);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 6):
 		qcom_socinfo->info.hw_plat_subtype =
 			__le32_to_cpu(info->hw_plat_subtype);
@@ -341,6 +344,7 @@  static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_u32("hardware_platform_subtype", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.hw_plat_subtype);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 5):
 		qcom_socinfo->info.accessory_chip =
 			__le32_to_cpu(info->accessory_chip);
@@ -348,23 +352,27 @@  static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_u32("accessory_chip", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.accessory_chip);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 4):
 		qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
 
 		debugfs_create_u32("platform_version", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.plat_ver);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 3):
 		qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
 
 		debugfs_create_u32("hardware_platform", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.hw_plat);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 2):
 		qcom_socinfo->info.raw_ver  = __le32_to_cpu(info->raw_ver);
 
 		debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.raw_ver);
+		/* Fall through */
 	case SOCINFO_VERSION(0, 1):
 		DEBUGFS_ADD(info, build_id);
 		break;