diff mbox series

Revert "Bluetooth: hci_qca: Add delay for wcn3990 stability"

Message ID 20191021141827.11150-1-jeffrey.l.hugo@gmail.com (mailing list archive)
State Accepted
Commit bba79fee7a54ff5351fa36cb324d16b108a7ca06
Headers show
Series Revert "Bluetooth: hci_qca: Add delay for wcn3990 stability" | expand

Commit Message

Jeffrey Hugo Oct. 21, 2019, 2:18 p.m. UTC
This reverts commit cde9dde6e11a5ab54b6462cd46d82878926783bc.

The frame reassembly errors were root caused to a transient gpio issue.
The missing response was root caused to an issue with properly managing
RFR in the uart driver.  Addressing those root causes occurs outside of
hci_qca and eliminates the need for the 50ms delay, so remove it.

Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
---
 drivers/bluetooth/hci_qca.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Marcel Holtmann Oct. 21, 2019, 3:05 p.m. UTC | #1
Hi Jeffrey,

> This reverts commit cde9dde6e11a5ab54b6462cd46d82878926783bc.
> 
> The frame reassembly errors were root caused to a transient gpio issue.
> The missing response was root caused to an issue with properly managing
> RFR in the uart driver.  Addressing those root causes occurs outside of
> hci_qca and eliminates the need for the 50ms delay, so remove it.
> 
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/bluetooth/hci_qca.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 8ae91e0f8102..c591a8ba9d93 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1155,10 +1155,8 @@  static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
 		host_set_baudrate(hu, speed);
 
 error:
-		if (qca_is_wcn399x(soc_type)) {
-			msleep(50);
+		if (qca_is_wcn399x(soc_type))
 			hci_uart_set_flow_control(hu, false);
-		}
 
 		if (soc_type == QCA_WCN3990) {
 			/* Wait for the controller to send the vendor event