diff mbox series

[2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup

Message ID 20191210163530.2.I8d4cbb3d7ac5824f8e950c53038df8c27a512905@changeid (mailing list archive)
State Accepted
Commit a0f96390336af9b81c061851ae5f3e6527e33c2f
Headers show
Series [1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp | expand

Commit Message

Doug Anderson Dec. 11, 2019, 12:35 a.m. UTC
Make i2c7 symmetric with the other i2c busses and comment that we have
no internal pull because there is an external one.

Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rajendra Nayak Dec. 11, 2019, 4:37 a.m. UTC | #1
On 12/11/2019 6:05 AM, Douglas Anderson wrote:
> Make i2c7 symmetric with the other i2c busses and comment that we have
> no internal pull because there is an external one.
> 
> Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org>

> 
>   arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 5eab3a282eba..05d30a56eca9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -311,6 +311,8 @@ &qup_i2c7_default {
>   	pinconf {
>   		pins = "gpio6", "gpio7";
>   		drive-strength = <2>;
> +
> +		/* Has external pullup */
>   		bias-disable;
>   	};
>   };
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 5eab3a282eba..05d30a56eca9 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -311,6 +311,8 @@  &qup_i2c7_default {
 	pinconf {
 		pins = "gpio6", "gpio7";
 		drive-strength = <2>;
+
+		/* Has external pullup */
 		bias-disable;
 	};
 };