diff mbox series

[3/7] arm64: dts: qcom: sc7180: Add "#clock-cells" property to usb_1_ssphy

Message ID 20191212113540.3.Ia530e4065ca81f55ac8f89a400f6a0a084ff6712@changeid (mailing list archive)
State New, archived
Headers show
Series arm64: dts: sc7180: Make dtbs_check mostly happy | expand

Commit Message

Doug Anderson Dec. 12, 2019, 7:35 p.m. UTC 
Running "dtbs_check" yells:
  '#clock-cells' is a dependency of 'clock-output-names'

...and sure enough the bindings say we should have "#clock-cells".
Add it.

Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd Dec. 12, 2019, 9:56 p.m. UTC | #1 
Quoting Douglas Anderson (2019-12-12 11:35:39)
> Running "dtbs_check" yells:
>   '#clock-cells' is a dependency of 'clock-output-names'
> 
> ...and sure enough the bindings say we should have "#clock-cells".
> Add it.
> 
> Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Good catch!

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 1b2bb0b9c9e8..d114feade8e7 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1020,6 +1020,7 @@  usb_1_ssphy: lanes@88e9200 {
 				      <0 0x088e9600 0 0x128>,
 				      <0 0x088e9800 0 0x200>,
 				      <0 0x088e9a00 0 0x18>;
+				#clock-cells = <0>;
 				#phy-cells = <0>;
 				clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
 				clock-names = "pipe0";