| Message ID | 20191213064934.4112-1-saiprakash.ranjan@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e0b4f4e0cf7fa9d62628d4249c765ec18dffd143 |
| Headers | show |
| Series | watchdog: qcom: Use platform_get_irq_optional() for bark irq | expand |
On Thu 12 Dec 22:49 PST 2019, Sai Prakash Ranjan wrote: > platform_get_irq() prints an error message when the interrupt > is not available. So on platforms where bark interrupt is > not specified, following error message is observed on SDM845. > > [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found > > This is also seen on SC7180, SM8150 SoCs as well. > Fix this by using platform_get_irq_optional() instead. > > Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/watchdog/qcom-wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index a494543d3ae1..eb47fe5ed280 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > } > > /* check if there is pretimeout support */ > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > ret = devm_request_irq(dev, irq, qcom_wdt_isr, > IRQF_TRIGGER_RISING, > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation
On 12/12/19 10:49 PM, Sai Prakash Ranjan wrote: > platform_get_irq() prints an error message when the interrupt > is not available. So on platforms where bark interrupt is > not specified, following error message is observed on SDM845. > > [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found > > This is also seen on SC7180, SM8150 SoCs as well. > Fix this by using platform_get_irq_optional() instead. > > Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/qcom-wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index a494543d3ae1..eb47fe5ed280 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > } > > /* check if there is pretimeout support */ > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > ret = devm_request_irq(dev, irq, qcom_wdt_isr, > IRQF_TRIGGER_RISING, >
Quoting Sai Prakash Ranjan (2019-12-12 22:49:34) > platform_get_irq() prints an error message when the interrupt > is not available. So on platforms where bark interrupt is > not specified, following error message is observed on SDM845. > > [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found > > This is also seen on SC7180, SM8150 SoCs as well. > Fix this by using platform_get_irq_optional() instead. > > Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c index a494543d3ae1..eb47fe5ed280 100644 --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) } /* check if there is pretimeout support */ - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq > 0) { ret = devm_request_irq(dev, irq, qcom_wdt_isr, IRQF_TRIGGER_RISING,
platform_get_irq() prints an error message when the interrupt is not available. So on platforms where bark interrupt is not specified, following error message is observed on SDM845. [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found This is also seen on SC7180, SM8150 SoCs as well. Fix this by using platform_get_irq_optional() instead. Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> --- drivers/watchdog/qcom-wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)