| Message ID | 20191226064554.16803-3-rjliao@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/4] Bluetooth: hci_qca: Add QCA Rome power off support to the qca_power_off() | expand |
Hi Rocky, > This patch registers hdev->shutdown() callback and also sets > HCI_QUIRK_NON_PERSISTENT_SETUP for QCA Rome. It will power-off the BT chip > during hci down and power-on/initialize the chip again during hci up. > > Signed-off-by: Rocky Liao <rjliao@codeaurora.org> > --- > > Changes in v2: None > > drivers/bluetooth/hci_qca.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 45042aa27fa4..7e202041ed77 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1300,6 +1300,11 @@ static int qca_setup(struct hci_uart *hu) > } else { > bt_dev_info(hdev, "ROME setup"); > if (hu->serdev) { > + /* Enable NON_PERSISTENT_SETUP QUIRK to ensure to > + * execute setup for every hci up. > + */ > + set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks); > + hu->hdev->shutdown = qca_power_off; why are you setting it in the ->setup callback and not in the ->probe callback? Regards Marcel
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 45042aa27fa4..7e202041ed77 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1300,6 +1300,11 @@ static int qca_setup(struct hci_uart *hu) } else { bt_dev_info(hdev, "ROME setup"); if (hu->serdev) { + /* Enable NON_PERSISTENT_SETUP QUIRK to ensure to + * execute setup for every hci up. + */ + set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks); + hu->hdev->shutdown = qca_power_off; qcadev = serdev_device_get_drvdata(hu->serdev); gpiod_set_value_cansleep(qcadev->bt_en, 1); /* Controller needs time to bootup. */
This patch registers hdev->shutdown() callback and also sets HCI_QUIRK_NON_PERSISTENT_SETUP for QCA Rome. It will power-off the BT chip during hci down and power-on/initialize the chip again during hci up. Signed-off-by: Rocky Liao <rjliao@codeaurora.org> --- Changes in v2: None drivers/bluetooth/hci_qca.c | 5 +++++ 1 file changed, 5 insertions(+)