| Message ID | 20191227053215.423811-2-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: qcom: post mortem debug support | expand |
On Thu, Dec 26, 2019 at 09:32:08PM -0800, Bjorn Andersson wrote: > Add a devicetree binding for the Qualcomm periperal image loader > relocation info region found in the IMEM. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Changes since v1: > - New patch > > .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > new file mode 100644 > index 000000000000..715945c683ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm peripheral image loader relocation info binding > + > +description: > + This document defines the binding for describing the Qualcomm peripheral > + image loader relocation memory region, in IMEM, which is used for post mortem > + debugging of remoteprocs. > + > +maintainers: > + - Bjorn Andersson <bjorn.andersson@linaro.org> > + > +properties: > + compatible: > + const: qcom,pil-reloc-info > + > + offset: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Offset in the register map for the memory region Why not use 'reg' instead? > + > +examples: > + - | > + imem@146bf000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0 0x146bf000 0 0x1000>; > + > + pil-reloc { > + compatible ="qcom,pil-reloc-info"; > + offset = <0x94c>; > + }; > + }; > -- > 2.24.0 >
On Sat 04 Jan 13:38 PST 2020, Rob Herring wrote: > On Thu, Dec 26, 2019 at 09:32:08PM -0800, Bjorn Andersson wrote: > > Add a devicetree binding for the Qualcomm periperal image loader > > relocation info region found in the IMEM. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > > > Changes since v1: > > - New patch > > > > .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > new file mode 100644 > > index 000000000000..715945c683ed > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > @@ -0,0 +1,35 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm peripheral image loader relocation info binding > > + > > +description: > > + This document defines the binding for describing the Qualcomm peripheral > > + image loader relocation memory region, in IMEM, which is used for post mortem > > + debugging of remoteprocs. > > + > > +maintainers: > > + - Bjorn Andersson <bjorn.andersson@linaro.org> > > + > > +properties: > > + compatible: > > + const: qcom,pil-reloc-info > > + > > + offset: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Offset in the register map for the memory region > > Why not use 'reg' instead? > Because we have one prior example of subdevice of "imem", which is compatible "syscon-reboot-mode" and that binding uses "offset". That said, if you insist, reg (and ranges) would allow us to express the size of the region... Regards, Bjorn > > + > > +examples: > > + - | > > + imem@146bf000 { > > + compatible = "syscon", "simple-mfd"; > > + reg = <0 0x146bf000 0 0x1000>; > > + > > + pil-reloc { > > + compatible ="qcom,pil-reloc-info"; > > + offset = <0x94c>; > > + }; > > + }; > > -- > > 2.24.0 > >
On Sat, Jan 4, 2020 at 3:17 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Sat 04 Jan 13:38 PST 2020, Rob Herring wrote: > > > On Thu, Dec 26, 2019 at 09:32:08PM -0800, Bjorn Andersson wrote: > > > Add a devicetree binding for the Qualcomm periperal image loader > > > relocation info region found in the IMEM. > > > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > --- > > > > > > Changes since v1: > > > - New patch > > > > > > .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++ > > > 1 file changed, 35 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > > new file mode 100644 > > > index 000000000000..715945c683ed > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml > > > @@ -0,0 +1,35 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Qualcomm peripheral image loader relocation info binding > > > + > > > +description: > > > + This document defines the binding for describing the Qualcomm peripheral > > > + image loader relocation memory region, in IMEM, which is used for post mortem > > > + debugging of remoteprocs. > > > + > > > +maintainers: > > > + - Bjorn Andersson <bjorn.andersson@linaro.org> > > > + > > > +properties: > > > + compatible: > > > + const: qcom,pil-reloc-info > > > + > > > + offset: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: Offset in the register map for the memory region > > > > Why not use 'reg' instead? > > > > Because we have one prior example of subdevice of "imem", which is > compatible "syscon-reboot-mode" and that binding uses "offset". Not that I'm proposing this, but nothing should prevent both from coexisting. Rob
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml new file mode 100644 index 000000000000..715945c683ed --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm peripheral image loader relocation info binding + +description: + This document defines the binding for describing the Qualcomm peripheral + image loader relocation memory region, in IMEM, which is used for post mortem + debugging of remoteprocs. + +maintainers: + - Bjorn Andersson <bjorn.andersson@linaro.org> + +properties: + compatible: + const: qcom,pil-reloc-info + + offset: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Offset in the register map for the memory region + +examples: + - | + imem@146bf000 { + compatible = "syscon", "simple-mfd"; + reg = <0 0x146bf000 0 0x1000>; + + pil-reloc { + compatible ="qcom,pil-reloc-info"; + offset = <0x94c>; + }; + };
Add a devicetree binding for the Qualcomm periperal image loader relocation info region found in the IMEM. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Changes since v1: - New patch .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml